Bug 2150251

Summary: [RHEL9] cryptsetup --header parameter and device parameter points to same device corrupts the data
Product: Red Hat Enterprise Linux 9 Reporter: guazhang <guazhang>
Component: cryptsetupAssignee: Daniel Zaťovič <dzatovic>
Status: CLOSED ERRATA QA Contact: guazhang <guazhang>
Severity: high Docs Contact:
Priority: high    
Version: 9.2CC: agk, jbrassow, okozina, prajnoha
Target Milestone: rcKeywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: cryptsetup-2.6.0-2.el9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 2150254 (view as bug list) Environment:
Last Closed: 2023-05-09 08:23:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2150254    

Description guazhang@redhat.com 2022-12-02 10:16:52 UTC
Description of problem:
 cryptsetup --header parameter and device parameter points to same device corrupts the data, It must not even intialize encryption operation

Version-Release number of selected component (if applicable):
cryptsetup-2.4.3-5.el9.x86_64
5.14.0-202.el9.x86_64

How reproducible:


Steps to Reproduce:
1.  echo 'redhatredhat' |cryptsetup reencrypt  --encrypt /dev/loop0  --header  /dev/loop0  --type luks2  -q
2.
3.

Actual results:
pass

Expected results:
failed

Additional info:



[root@pnate-client-01 ~]# 
[root@pnate-client-01 ~]# echo 'redhatredhat' |cryptsetup reencrypt  --encrypt /dev/loop0  --header  /dev/loop0  --type luks2  -q
[root@pnate-client-01 ~]# $?
-bash: 0: command not found
[root@pnate-client-01 ~]# uname -a
Linux pnate-client-01.sqe.lab.eng.bos.redhat.com 5.14.0-202.el9.x86_64 #1 SMP PREEMPT_DYNAMIC Mon Nov 28 08:49:47 EST 2022 x86_64 x86_64 x86_64 GNU/Linux
[root@pnate-client-01 ~]# 


also reproduce with cryptsetup-2.6.0-1.el9.x86_64

Comment 3 Ondrej Kozina 2022-12-14 09:45:10 UTC
Fixed in upstream with: https://gitlab.com/cryptsetup/cryptsetup/-/merge_requests/463

Comment 4 guazhang@redhat.com 2022-12-20 04:26:36 UTC
Hi,

[root@storageqe-104 ~]# echo 'redhatredhat' |cryptsetup reencrypt  --encrypt /dev/loop0  --header  /dev/loop0  --type luks2  -q
Encryption without detached header (--header) is not possible without data device size reduction (--reduce-device-size).
[root@storageqe-104 ~]# $?
-bash: 1: command not found
[root@storageqe-104 ~]# 

test pass with fixed package,

Comment 9 errata-xmlrpc 2023-05-09 08:23:06 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (cryptsetup bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:2534