Bug 2150311

Summary: Hammer simplified ACS creation shouldn't allow user to enter product names
Product: Red Hat Satellite Reporter: Ian Ballou <iballou>
Component: RepositoriesAssignee: Chris Roberts <chrobert>
Status: CLOSED ERRATA QA Contact: Vladimír Sedmík <vsedmik>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.13.0CC: chrobert, pcreech, vsedmik
Target Milestone: 6.13.0Keywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: rubygem-hammer_cli_katello-1.7.2 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-05-03 13:23:27 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ian Ballou 2022-12-02 13:36:55 UTC
Product names are not unique across products, so an organization is required. However, ACSs are not scoped by organization since they are global. So, products should only be entered by ID.

Here is how it looks today:

 --product[s|-ids] LIST               Names/ids of products to copy repository information from into a Simplified
                                      Alternate Content Source. Products must include at least one repository of the
                                      chosen content type.

It should just be --product-ids

Comment 1 Ian Ballou 2022-12-02 13:36:58 UTC
Created from redmine issue https://projects.theforeman.org/issues/35815

Comment 2 Ian Ballou 2022-12-02 13:36:59 UTC
Upstream bug assigned to None

Comment 4 Bryan Kearney 2023-01-10 20:03:09 UTC
Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/35815 has been resolved.

Comment 6 Vladimír Sedmík 2023-02-10 11:20:33 UTC
Verified in 6.13.0 snap 10 (rubygem-hammer_cli_katello-1.7.2-1.el8sat.noarch):

[root@sat ~]# hammer alternate-content-source create --help
Usage:
    hammer alternate-content-source create [OPTIONS]

Options:
 --alternate-content-source-type ENUM The Alternate Content Source type
                                      Possible value(s): 'custom', 'simplified', 'rhui'
 --base-url VALUE                     Base URL for finding alternate content
 --content-type ENUM                  The content type for the Alternate Content Source
                                      Possible value(s): 'file', 'yum'
 --description VALUE                  Description for the alternate content source
 --name VALUE                         Name of the alternate content source
 --product-ids LIST                   Ids of products to copy repository information from into a Simplified Alternate
                                      Content Source. Products must include at least one repository of the chosen
                                      content type.
 ...

[root@sat ~]# hammer alternate-content-source create --alternate-content-source-type simplified --name TestSACS --smart-proxy-ids 1 --products ZOO
Could not create the Alternate Content Source.:
  Error: Unrecognised option '--products'.
  
  See: 'hammer alternate-content-source create --help'.

[root@sat ~]# hammer alternate-content-source create --alternate-content-source-type simplified --name TestSACS --smart-proxy-ids 1 --product-ids 3
Alternate Content Source created.

Comment 9 errata-xmlrpc 2023-05-03 13:23:27 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.13 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:2097