Bug 2150517

Summary:	Review Request: rust-svg_metadata - Extracts metadata (like the viewBox, width, and height) from SVG graphics
Product:	[Fedora] Fedora	Reporter:	Kalev Lember <klember>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review?
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-03-24 09:43:12 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Kalev Lember 2022-12-03 16:04:43 UTC

Spec URL: https://kalev.fedorapeople.org/rust-svg_metadata.spec
SRPM URL: https://kalev.fedorapeople.org/rust-svg_metadata-0.4.2-8.fc38.src.rpm
Description:
Extracts metadata (like the viewBox, width, and height) from SVG graphics.

Fedora Account System Username: kalev

Note that this is a re-review as the package was retired from Fedora because nothing used it any more.

Comment 1 Kalev Lember 2022-12-03 16:08:02 UTC

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=94884101

The package is at version 0.4.2 because 0.4.3 needs newer rust-roxmltree than what's currently in Fedora. Should be easy to update once roxmltree is updated.

Comment 2 Kalev Lember 2022-12-03 18:43:20 UTC

I went ahead and updated rust-roxmltree to 0.15.1 that this package needs and with this I was able to update it to 0.4.3:

* Sat Dec 03 2022 Kalev Lember <klember> 0.4.3-1
- Update to 0.4.3

Spec URL: https://kalev.fedorapeople.org/rust-svg_metadata.spec
SRPM URL: https://kalev.fedorapeople.org/rust-svg_metadata-0.4.3-1.fc38.src.rpm

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=94889493

Comment 3 Fabio Valentini 2022-12-12 12:23:41 UTC

Looks good to me, with one possible exception:

> ## Credits
> 
> The SVG fixtures used for testing are provided by
> 
> * [Openclipart](https://en.wikipedia.org/wiki/Openclipart)
> * [SVG Specification Examples](https://www.w3.org/TR/SVG2/)
> * [W3C SVG Working Group](https://www.w3.org/Graphics/SVG/)
> 
> under their respective licenses.

This applies to the files under the "/fixtures" directory.

Openclipart: CC0-1.0, is OK for content.

SVG Specification examples:
Seems to be covered by this license: https://www.w3.org/Consortium/Legal/2015/doc-license
Not sure if it's OK for content in Fedora.

W3C SVG Working Group: No idea where examples came from or what license applies to them.

It might be easiest to just nuke the "fixtures" directory and use a "clean" source tarball ...
Not sure why / how this wasn't caught during the last package review (but it seems to have been a bit ... rushed: https://bugzilla.redhat.com/show_bug.cgi?id=1910871)

Comment 4 Kalev Lember 2023-03-24 09:43:12 UTC

Sorry for the delay on my part!

I think I'm actually going to close this review request: I was packaging svg_metadata for loupe, but loupe has dropped the dep in https://gitlab.gnome.org/Incubator/loupe/-/commit/42d558d22fcc870bffd7ed6d5550ab9e306a4687 just a few days ago so I don't need it packaged any more.

Comment 5 Fabio Valentini 2023-03-24 09:49:25 UTC

Thanks for the update!

The linked commit sure looks like dropping svg_metadata resulted in a lot fewer dependencies ... so that's definitely nice from a packaging point of view :)