Bug 2150615

Summary: Review Request: rust-critical-section - Cross-platform critical section
Product: [Fedora] Fedora Reporter: Fabio Valentini <decathorpe>
Component: Package ReviewAssignee: Michel Lind <michel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: michel, package-review
Target Milestone: ---Flags: michel: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-12-21 13:08:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2138517, 2150616    

Description Fabio Valentini 2022-12-04 13:53:37 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-critical-section.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-critical-section-1.1.1-1.fc37.src.rpm

Description:
Cross-platform critical section.

Fedora Account System Username: decathorpe

koji scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=94926798

Comment 1 Michel Lind 2022-12-20 21:03:13 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 2 Fabio Valentini 2022-12-20 22:01:29 UTC
Thanks for the review!

$ fedpkg request-repo rust-critical-section 2150615 
https://pagure.io/releng/fedora-scm-requests/issue/49923
$ fedpkg request-branch --repo rust-critical-section f37 
https://pagure.io/releng/fedora-scm-requests/issue/49924
$ fedpkg request-branch --repo rust-critical-section f36 
https://pagure.io/releng/fedora-scm-requests/issue/49925
$ fedpkg request-branch --repo rust-critical-section epel9 
https://pagure.io/releng/fedora-scm-requests/issue/49926

Comment 3 Gwyn Ciesla 2022-12-20 22:15:37 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-critical-section

Comment 4 Fedora Update System 2022-12-21 13:06:06 UTC
FEDORA-2022-790832c647 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-790832c647

Comment 5 Fedora Update System 2022-12-21 13:08:22 UTC
FEDORA-2022-790832c647 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.