Bug 2150851

Summary: Review Request: python-argon2-cffi-bindings - Low-level CFFI bindings for Argon2
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: Package ReviewAssignee: Ben Beasley <code>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: code, package-review
Target Milestone: ---Flags: code: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-12-05 16:52:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Miro Hrončok 2022-12-05 12:38:32 UTC
Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-argon2-cffi-bindings.spec
SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python-argon2-cffi-bindings-21.2.0-1.fc35.src.rpm

This package provides low-level CFFI bindings to the Argon2 password hashing

If you want to hash passwords in an application,
this package is not for you.
Have a look at argon2-cffi with its high-level abstractions!

These bindings have been extracted from argon2-cffi and it remains its main
consumer. However, they may be used by other packages that want to use the
Argon2 library without dealing with C-related complexities.

Fedora Account System Username: churchyard

Comment 1 Ben Beasley 2022-12-05 14:49:40 UTC
Everything looks fine here. The package is APPROVED. Thanks for picking up python-argon2-cffi.

Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

===== MUST items =====

[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.

     The file in question,


     is a correctly-packaged Python extension module and is not in the linker
     search path.

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "MIT License", "*No copyright* MIT
     License". 19 files have unknown license. Detailed output of
     licensecheck in /home/reviewer/2150851-python-argon2-cffi-

     Confirmed License is *SPDX* MIT.

[x]: License file installed when any subpackage combination is installed.

     Confirmed license file is handled by pyproject-rpm-macros:

       $ rpm -qL -p results/python3-argon2-cffi-bindings-21.2.0-1.fc38.x86_64.rpm 

[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.

     Bundled libargon2 is correctly removed in %prep, and the package links
     against the system library.

[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

[x]: Python eggs must not download any dependencies during the build
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
[x]: Package functions as described.

     (based on tests passing)

[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.

Cannot parse rpmlint output:

Rpmlint (installed packages)
============================ rpmlint session starts ============================
rpmlint: 2.4.0
checks: 31, packages: 2

python3-argon2-cffi-bindings.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_argon2_cffi_bindings/_ffi.abi3.so PyObject_CallMethod	(/usr/lib64/python3.11/site-packages/_argon2_cffi_bindings/_ffi.abi3.so)
python3-argon2-cffi-bindings.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_argon2_cffi_bindings/_ffi.abi3.so PyEval_RestoreThread	(/usr/lib64/python3.11/site-packages/_argon2_cffi_bindings/_ffi.abi3.so)
python3-argon2-cffi-bindings.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_argon2_cffi_bindings/_ffi.abi3.so _Py_Dealloc	(/usr/lib64/python3.11/site-packages/_argon2_cffi_bindings/_ffi.abi3.so)
python3-argon2-cffi-bindings.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_argon2_cffi_bindings/_ffi.abi3.so PyObject_Malloc	(/usr/lib64/python3.11/site-packages/_argon2_cffi_bindings/_ffi.abi3.so)
python3-argon2-cffi-bindings.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_argon2_cffi_bindings/_ffi.abi3.so PyObject_Free	(/usr/lib64/python3.11/site-packages/_argon2_cffi_bindings/_ffi.abi3.so)
python3-argon2-cffi-bindings.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_argon2_cffi_bindings/_ffi.abi3.so PyLong_FromLong	(/usr/lib64/python3.11/site-packages/_argon2_cffi_bindings/_ffi.abi3.so)
python3-argon2-cffi-bindings.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_argon2_cffi_bindings/_ffi.abi3.so PyLong_FromVoidPtr	(/usr/lib64/python3.11/site-packages/_argon2_cffi_bindings/_ffi.abi3.so)
python3-argon2-cffi-bindings.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_argon2_cffi_bindings/_ffi.abi3.so PyArg_UnpackTuple	(/usr/lib64/python3.11/site-packages/_argon2_cffi_bindings/_ffi.abi3.so)
python3-argon2-cffi-bindings.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_argon2_cffi_bindings/_ffi.abi3.so PyErr_Occurred	(/usr/lib64/python3.11/site-packages/_argon2_cffi_bindings/_ffi.abi3.so)
python3-argon2-cffi-bindings.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_argon2_cffi_bindings/_ffi.abi3.so PyImport_ImportModule	(/usr/lib64/python3.11/site-packages/_argon2_cffi_bindings/_ffi.abi3.so)
python3-argon2-cffi-bindings.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/_argon2_cffi_bindings/_ffi.abi3.so PyEval_SaveThread	(/usr/lib64/python3.11/site-packages/_argon2_cffi_bindings/_ffi.abi3.so)
 2 packages and 0 specfiles checked; 0 errors, 11 warnings, 0 badness; has taken 0.0 s 

Unversioned so-files
python3-argon2-cffi-bindings: /usr/lib64/python3.11/site-packages/_argon2_cffi_bindings/_ffi.abi3.so

Source checksums
https://files.pythonhosted.org/packages/source/a/argon2-cffi-bindings/argon2-cffi-bindings-21.2.0.tar.gz :
  CHECKSUM(SHA256) this package     : bb89ceffa6c791807d1305ceb77dbfacc5aa499891d2c55661c6459651fc39e3
  CHECKSUM(SHA256) upstream package : bb89ceffa6c791807d1305ceb77dbfacc5aa499891d2c55661c6459651fc39e3

python3-argon2-cffi-bindings (rpmlib, GLIBC filtered):

python-argon2-cffi-bindings-debugsource (rpmlib, GLIBC filtered):



Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -b 2150851
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic, Python
Disabled plugins: C/C++, Haskell, R, fonts, Ocaml, Perl, PHP, SugarActivity, Java

Comment 2 Miro Hrončok 2022-12-05 16:01:08 UTC
Thank you.


Comment 3 Fedora Update System 2022-12-05 16:49:49 UTC
FEDORA-2022-fde0d1fca6 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-fde0d1fca6

Comment 4 Fedora Update System 2022-12-05 16:52:26 UTC
FEDORA-2022-fde0d1fca6 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.