Bug 2150967
| Summary: | memory safety violation | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Alexander Sosedkin <asosedki> | ||||
| Component: | python-zstd | Assignee: | Michel Lind <michel> | ||||
| Status: | CLOSED EOL | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 37 | CC: | michel, security-response-team, zmiele | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2023-12-06 11:38:29 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 2169048 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
Created attachment 1930155 [details]
valgrind log obtained on Fedora 37
This is not a security issue. No memory boundary looks to be crossed here. The issue here is that python-zstd was using a deprecated function ZSTD_getDecompressedSize() which is obseleted and replaced by ZSTD_getFrameContentSize() in zstd. Instead of failing after ZSTD_getDecompressedSize() returns a 0, python-zstd continued to attempt to compress the data since it may be compressable but have an unknown content size which would make it necessary to use streaming mode. Eventually this returns the smallest size frame returned by ZSTD_COMPRESSBOUND(). As Alexander mentions, this is resolved in 1.5.2.6. ack. Will prioritize getting this updated, thanks! This message is a reminder that Fedora Linux 37 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora Linux 37 on 2023-12-05. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a 'version' of '37'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, change the 'version' to a later Fedora Linux version. Note that the version field may be hidden. Click the "Show advanced fields" button if you do not see it. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora Linux 37 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora Linux, you are encouraged to change the 'version' to a later version prior to this bug being closed. Fedora Linux 37 entered end-of-life (EOL) status on None. Fedora Linux 37 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora Linux please feel free to reopen this bug against that version. Note that the version field may be hidden. Click the "Show advanced fields" button if you do not see the version field. If you are unable to reopen this bug, please file a new report against an active release. Thank you for reporting this bug and we are sorry it could not be fixed. |
Description of problem: compressing an empty bytestring violates memory safety Version-Release number of selected component: * python3-zstd-1.4.5.1-6.fc36.x86_64 * python3-zstd-1.4.5.1-8.fc37.x86_64 How reproducible: reliably Steps to Reproduce: 1. python3 -c "import zstd; print(repr(zstd.compress(b'')))" 2. valgrind --track-origins=yes python3 -c "import zstd; print(repr(zstd.compress(b'')))" > valgrind.log Actual results (Fedora 36): b"\xe4\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00 \x00'ModuleSpec' object has no attribute '_initializ" Actual results (Fedora 37): b'\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00 \x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00 \x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00 \x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00 \x00\x00\x00\x00' Expected results: b'(\xb5/\xfd \x00\x01\x00\x00' Additional info: https://github.com/sergey-dryabzhinsky/python-zstd/releases/tag/v1.5.2.6 should have the fix