Bug 2150992

Summary: perl-generators 1.14 started to create bogus dependencies for relative imports, e.g. perl(.::t/lifecycles/utils.pl)
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: perl-generatorsAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: cra, jplesnik, mspacek, perl-devel, ppisar
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: perl-generators-1.15-1.fc38 perl-generators-1.15-1.fc37 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-12-16 01:56:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Miro Hrončok 2022-12-05 19:34:03 UTC
Description of problem:
Between perl-generators-1.13-8.fc37 and perl-generators-1.14-1.fc38 a new boghus dependency started to be generated for rt-tests.

Use the rt package from this commit: https://src.fedoraproject.org/rpms/rt/c/78d6db9676df2a5032f42471348e20ce5d37ceda?branch=rawhide (the bigus require was later filtered out manually).


perl-generators-1.13-8.fc37:
$ rpm -qRp rt-tests-5.0.3-2.fc38.noarch.rpm
/bin/sh
/usr/bin/bash
/usr/bin/perl
/usr/bin/prove
/usr/bin/rm
perl(CGI::PSGI)
perl(DBD::SQLite)
...


perl-generators-1.14-1.fc38:
$ rpm -qRp rt-tests-5.0.3-2.fc38.noarch.rpm
/bin/sh
/usr/bin/bash
/usr/bin/perl
/usr/bin/prove
/usr/bin/rm
perl(.::t/lifecycles/utils.pl)
perl(CGI::PSGI)
perl(DBD::SQLite)
...


$ rg -F 't/lifecycles/utils.pl' rt-5.0.3
rt-5.0.3/t/lifecycles/types.t
4:BEGIN {require  './t/lifecycles/utils.pl'};

rt-5.0.3/t/lifecycles/basics.t
4:BEGIN {require  './t/lifecycles/utils.pl'};

rt-5.0.3/t/lifecycles/dates.t
4:BEGIN {require './t/lifecycles/utils.pl'};

rt-5.0.3/t/lifecycles/moving.t
4:BEGIN {require './t/lifecycles/utils.pl'};

rt-5.0.3/t/lifecycles/unresolved-deps.t
4:BEGIN {require  './t/lifecycles/utils.pl'};

rt-5.0.3/t/lifecycles/unprivileged.t
4:BEGIN { require './t/lifecycles/utils.pl' }

rt-5.0.3/t/web/lifecycle_mappings.t
4:BEGIN { require './t/lifecycles/utils.pl' }

rt-5.0.3/t/web/lifecycle_rights.t
4:BEGIN {require './t/lifecycles/utils.pl'};


Version-Release number of selected component (if applicable): perl-generators-1.14-1.fc38


How reproducible: always


Steps to Reproduce:
1. build rt from 78d6db9676df2a5032f42471348e20ce5d37ceda

Actual results:
perl(.::t/lifecycles/utils.pl) is required by rt-tests-5.0.3-2.fc38

Expected results:
perl(.::t/lifecycles/utils.pl) is not required by rt-tests-5.0.3-2.fc38

Additional info:
See https://bugzilla.redhat.com/show_bug.cgi?id=2148952#c6

Comment 1 Charles R. Anderson 2022-12-06 00:09:24 UTC
I'm sorry to say this was caused by my fix for bug #2029995.  I'm not sure what the proper fix should be.

Comment 2 Petr Pisar 2022-12-06 09:58:14 UTC
> $ rpm -qRp rt-tests-5.0.3-2.fc38.noarch.rpm
[...]
> perl(.::t/lifecycles/utils.pl)

I think this is a bug in the generators. Relative imports (./) should be ignored.

t/web/lifecycle_rights.t:4:BEGIN {require './t/lifecycles/utils.pl'};

> perl(CGI::PSGI)

This dependency is correct:

t/web/redirect.t:5:use CGI::PSGI;

Comment 3 Miro Hrončok 2022-12-06 16:21:36 UTC
(In reply to Petr Pisar from comment #2)
> > perl(CGI::PSGI)
> 
> This dependency is correct:
> 
> t/web/redirect.t:5:use CGI::PSGI;

Yes, I never said it is not.

Comment 4 Fedora Update System 2022-12-07 06:59:39 UTC
FEDORA-2022-848ebdeccf has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-848ebdeccf

Comment 5 Fedora Update System 2022-12-08 02:09:50 UTC
FEDORA-2022-848ebdeccf has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-848ebdeccf`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-848ebdeccf

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2022-12-16 01:56:22 UTC
FEDORA-2022-848ebdeccf has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.