Bug 2151202

Summary: Bad permissions for files shipped by libvirt-client
Product: Red Hat Enterprise Linux 9 Reporter: Renaud Métrich <rmetrich>
Component: libvirtAssignee: Michal Privoznik <mprivozn>
libvirt sub component: CLI & API QA Contact: yalzhang <yalzhang>
Status: CLOSED ERRATA Docs Contact:
Severity: high    
Priority: high CC: jdenemar, jsuchane, lmen, mprivozn, virt-maint, ymankad
Version: 9.2Keywords: Triaged, Upstream, ZStream
Target Milestone: rcFlags: pm-rhel: mirror+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: libvirt-9.0.0-1.el9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 2153688 2158208 2158209 (view as bug list) Environment:
Last Closed: 2023-05-09 07:27:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version: 9.0.0
Embargoed:
Bug Depends On:    
Bug Blocks: 2158208, 2158209    

Description Renaud Métrich 2022-12-06 10:31:24 UTC 
Description of problem:

The following files changed permissions to 775 since updating to libvirt-client-8.0.0-5.module+el8.6.0+14480+c0a3aa0f:
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------
# ls -al /usr/bin/virt-*-validate
-rwxrwxr-x. 1 root root 9772 Mar 16  2022 /usr/bin/virt-pki-validate
-rwxrwxr-x. 1 root root 2840 Mar 16  2022 /usr/bin/virt-xml-validate
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------
All new releases are affected.

This was fine until the rebase happened. Last correct package is libvirt-client-6.0.0-37.1.module+el8.5.0+13858+39fdc467:
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------
# ls -al /usr/bin/virt-*-validate
-rwxr-xr-x. 1 root root 25568 Jan 13  2022 /usr/bin/virt-host-validate
-rwxr-xr-x. 1 root root  9772 Jan 13  2022 /usr/bin/virt-pki-validate
-rwxr-xr-x. 1 root root  2840 Jan 13  2022 /usr/bin/virt-xml-validate
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------

This breaks DISA/STIG rule xccdf_org.ssgproject.content_rule_file_permissions_binary_dirs.

Version-Release number of selected component (if applicable):

libvirt-client-8.0.0-5.module+el8.6.0+14480+c0a3aa0f and later

How reproducible:

N/A
Comment 1 Michal Privoznik 2022-12-08 08:54:03 UTC 
Merged upstream as:

commit e771e32f15ff2b263ca70306d93080541a96792b
Author:     Michal Prívozník <mprivozn>
AuthorDate: Thu Dec 8 08:39:24 2022 +0100
Commit:     Michal Prívozník <mprivozn>
CommitDate: Thu Dec 8 09:26:56 2022 +0100

    tools: Fix install_mode for some scripts
    
    Scripts from the following list were installed with group write
    bit set: virt-xml-validate, virt-pki-validate,
    virt-sanlock-cleanup, libvirt-guests.sh. This is very unusual and
    in contrast with the way other scripts/binaries are installed.
    
    Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2151202
    Signed-off-by: Michal Privoznik <mprivozn>
    Reviewed-by: Peter Krempa <pkrempa>
    Reviewed-by: Jiri Denemark <jdenemar>

v8.10.0-81-ge771e32f15
Comment 12 yalzhang@redhat.com 2023-01-11 05:54:50 UTC 
Test on upstream v9.0.0-rc1-5-ga5738ab74c, the result is as expected:
# ls -al /usr/bin/virt-*-validate 
-rwxr-xr-x. 1 root root 29392 Jan 11 04:12 /usr/bin/virt-host-validate
-rwxr-xr-x. 1 root root  9838 Jan 11 03:16 /usr/bin/virt-pki-validate
-rwxr-xr-x. 1 root root 46175 Jan 10 15:37 /usr/bin/virt-qemu-sev-validate
-rwxr-xr-x. 1 root root  3134 Jan 11 03:16 /usr/bin/virt-xml-validate
Comment 15 yalzhang@redhat.com 2023-02-02 10:46:44 UTC 
verify it on libvirt-client-9.0.0-3.el9.x86_64, the result is as expected.
# ls -al /usr/bin/virt-*-validate
-rwxr-xr-x. 1 root root 28136 Feb  1 08:07 /usr/bin/virt-host-validate
-rwxr-xr-x. 1 root root  9838 Feb  1 08:06 /usr/bin/virt-pki-validate
-rwxr-xr-x. 1 root root  3134 Feb  1 08:06 /usr/bin/virt-xml-validate
Comment 17 errata-xmlrpc 2023-05-09 07:27:43 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (libvirt bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:2171