Bug 2151511

Summary: Add a warning message when agents validation is omitted
Product: Red Hat Enterprise Linux 8 Reporter: Michal Mazourek <mmazoure>
Component: pcsAssignee: Ondrej Mular <omular>
Status: CLOSED ERRATA QA Contact: cluster-qe <cluster-qe>
Severity: low Docs Contact:
Priority: medium    
Version: 8.8CC: cluster-maint, idevat, mlisik, mpospisi, omular, tojeline
Target Milestone: rcKeywords: Triaged
Target Release: 8.8   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: pcs-0.10.15-2.el8 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of:
: 2151524 (view as bug list) Environment:
Last Closed: 2023-05-16 08:12:42 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Michal Mazourek 2022-12-07 12:30:45 UTC
Description of problem:
When a resource has an invalid option, validate check is omitted on purpose (to have a chance to change all invalid options independently to valid values). This is a correct behavior, however could be improved by printing a warning message, that the validation check is omitted.


Version-Release number of selected component (if applicable):
pcs-0.10.14-6.el8


How reproducible:
always


Steps to Reproduce:
[root@virt-137 ~]# pcs resource create test_ip_1 ocf:heartbeat:IPaddr2 ip=192.168.2.17
[root@virt-137 ~]# pcs resource update test_ip_1 ip=1.2.3.4 --force
Warning: Validation result from agent:
  Dec 05 16:46:51 ERROR: Unable to find nic or netmask.
  ocf-exit-reason:[findif] failed
[root@virt-137 ~]# pcs resource config test_ip_1 | grep ip=
    ip=1.2.3.4
[root@virt-137 ~]# pcs resource update test_ip_1 ip=invalid
[root@virt-137 ~]# echo $?
0
[root@virt-137 ~]# pcs resource config test_ip_1 | grep ip=
    ip=invalid


Actual results:
No warning is printed when the validation is omitted


Expected results:
A warning is present when the validation is omitted

Comment 1 Ondrej Mular 2022-12-12 10:14:17 UTC
Upstream patch:
https://github.com/ClusterLabs/pcs/commit/3776ab11756dfc4e1eedb5dab1430762bbb3860c

Test:
[root@rhel87-node1 pcs]# pcs resource create test_ip_1 ocf:heartbeat:IPaddr2 ip=1.2.3.4 --force
Warning: Validation result from agent:
  Dec 12 10:56:12 ERROR: Unable to find nic or netmask.
  ocf-exit-reason:[findif] failed
[root@rhel87-node1 pcs]# pcs resource update test_ip_1 ip=invalid
Warning: The resource was misconfigured before the update, therefore agent self-validation will not be run for the updated configuration. Validation output of the original configuration:
  Dec 12 10:56:41 ERROR: Unable to find nic or netmask.
  ocf-exit-reason:[findif] failed
[root@rhel87-node1 pcs]# echo $?
0

Comment 2 Michal Pospisil 2022-12-19 10:28:10 UTC
DevTestResults:

[root@r08-08-a ~]# rpm -q pcs
pcs-0.10.15-2.el8.x86_64

[root@r08-08-a ~]# pcs resource create test_ip_1 ocf:heartbeat:IPaddr2 ip=1.2.3.4 --force
Warning: Validation result from agent:
 Dec 16 17:55:55 ERROR: Unable to find nic or netmask.
 ocf-exit-reason:[findif] failed

[root@r08-08-a ~]# pcs resource update test_ip_1 ip=invalid
Warning: The resource was misconfigured before the update, therefore agent self-validation will not be run for the updated configuration. Validation output of the original configuration:
 Dec 16 17:56:09 ERROR: Unable to find nic or netmask.
 ocf-exit-reason:[findif] failed

Comment 8 Michal Mazourek 2023-01-30 15:33:42 UTC
This was tested as a part of this verification - bz2159454 comment 8.
Switching to VERIFIED for pcs-0.10.15-3.el8.

Comment 11 errata-xmlrpc 2023-05-16 08:12:42 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (pcs bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:2738