Bug 2151524

Summary:	Add a warning message when agents validation is omitted
Product:	Red Hat Enterprise Linux 9	Reporter:	Ondrej Mular <omular>
Component:	pcs	Assignee:	Ondrej Mular <omular>
Status:	CLOSED ERRATA	QA Contact:	cluster-qe <cluster-qe>
Severity:	low	Docs Contact:
Priority:	medium
Version:	9.2	CC:	cluster-maint, cluster-qe, idevat, mlisik, mmazoure, mpospisi, omular, tojeline
Target Milestone:	rc	Keywords:	Triaged
Target Release:	9.2
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	pcs-0.11.4-2.el9	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:	2151511	Environment:
Last Closed:	2023-05-09 07:18:34 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ondrej Mular 2022-12-07 13:05:26 UTC

+++ This bug was initially created as a clone of Bug #2151511 +++

Description of problem:
When a resource has an invalid option, validate check is omitted on purpose (to have a chance to change all invalid options independently to valid values). This is a correct behavior, however could be improved by printing a warning message, that the validation check is omitted.


Version-Release number of selected component (if applicable):
pcs-0.10.14-6.el8


How reproducible:
always


Steps to Reproduce:
[root@virt-137 ~]# pcs resource create test_ip_1 ocf:heartbeat:IPaddr2 ip=192.168.2.17
[root@virt-137 ~]# pcs resource update test_ip_1 ip=1.2.3.4 --force
Warning: Validation result from agent:
  Dec 05 16:46:51 ERROR: Unable to find nic or netmask.
  ocf-exit-reason:[findif] failed
[root@virt-137 ~]# pcs resource config test_ip_1 | grep ip=
    ip=1.2.3.4
[root@virt-137 ~]# pcs resource update test_ip_1 ip=invalid
[root@virt-137 ~]# echo $?
0
[root@virt-137 ~]# pcs resource config test_ip_1 | grep ip=
    ip=invalid


Actual results:
No warning is printed when the validation is omitted


Expected results:
A warning is present when the validation is omitted

Comment 1 Ondrej Mular 2022-12-12 10:11:15 UTC

Upstream patch:
https://github.com/ClusterLabs/pcs/commit/05760c5dc5a9b24591b88eb2414a64260daedb18

Test:
[root@rhel91-node1 pcs]# pcs resource create httpd apache --force
Assumed agent name 'ocf:heartbeat:apache' (deduced from 'apache')
Warning: Validation result from agent:
  ocf-exit-reason:apache httpd program not found
  ocf-exit-reason:environment is invalid, resource considered stopped
[root@rhel91-node1 pcs]# pcs resource update httpd configfile=/dev/null
Warning: The resource was misconfigured before the update, therefore agent self-validation will not be run for the updated configuration. Validation output of the original configuration:
  ocf-exit-reason:apache httpd program not found
  ocf-exit-reason:environment is invalid, resource considered stopped
[root@rhel91-node1 pcs]# echo $?
0

Comment 2 Michal Pospisil 2022-12-15 14:14:26 UTC

DevTestResults:

[root@r09-02-a ~]# rpm -q pcs
pcs-0.11.4-2.el9.x86_64

[root@r09-02-a pcs]# pcs resource create httpd apache --force       
Assumed agent name 'ocf:heartbeat:apache' (deduced from 'apache')
Warning: Validation result from agent:
 ocf-exit-reason:apache httpd program not found
 ocf-exit-reason:environment is invalid, resource considered stopped

[root@r09-02-a pcs]# pcs resource update httpd configfile=/dev/null
Warning: The resource was misconfigured before the update, therefore agent self-validation will not be run for the updated configuration. Validation output of the original configuration:
 ocf-exit-reason:apache httpd program not found
 ocf-exit-reason:environment is invalid, resource considered stopped

Comment 6 Michal Mazourek 2023-01-30 15:27:47 UTC

This was tested as a part of this verification - bz2159454 comment 8.
Switching to VERIFIED for pcs-0.11.4-4.el9.

Comment 8 errata-xmlrpc 2023-05-09 07:18:34 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (pcs bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:2151