Bug 2151535

Summary: libblockdev-nvme: Fix getting NVMe namespace identifiers
Product: Red Hat Enterprise Linux 9 Reporter: Vojtech Trefny <vtrefny>
Component: libblockdevAssignee: Tomáš Bžatek <tbzatek>
Status: CLOSED ERRATA QA Contact: guazhang <guazhang>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 9.2CC: guazhang
Target Milestone: rcKeywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libblockdev-2.28-4.el9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-05-09 07:28:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2123337    

Description Vojtech Trefny 2022-12-07 13:16:18 UTC
We need to show the NID when selecting namespaces in the installer, so libblockdev needs to provide it for anaconda to show.

Comment 2 Tomáš Bžatek 2022-12-09 16:08:31 UTC
This small related change might fix some corner cases: https://github.com/storaged-project/libblockdev/pull/827

Comment 3 Tomáš Bžatek 2022-12-09 16:10:47 UTC
(In reply to Vojtech Trefny from comment #0)
> We need to show the NID when selecting namespaces in the installer, so
> libblockdev needs to provide it for anaconda to show.

The "NID" here is actually a list of namespace identifiers that we already provided: EUI64, NGUID and (Namespace) UUID. No new API is needed, the proposed patch above is a nice-to-have.

Comment 4 Vojtech Trefny 2023-01-05 14:16:30 UTC
I'we changed summary of the bug, as Tomas said, we already had those identifiers in libblockdev, we are just now better in making sure we get those identifiers. The biggest visible change is that instead of returning "0000000000000000" if we can't get the EUI64, we'll return NULL/None.

Comment 6 guazhang@redhat.com 2023-01-30 03:02:57 UTC
Hi,

libblockdev regression testing have tested pass.

Comment 11 errata-xmlrpc 2023-05-09 07:28:51 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (libblockdev bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:2172