Bug 2151635

Summary: mkksiso fails to add inst.ks= grub cmdline option when creating Fedora 37/Rawhide kickstart isos
Product: [Fedora] Fedora Reporter: Elia F <elia.farin>
Component: loraxAssignee: Brian Lane <bcl>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: anaconda-maint-list, bcl, reallylongword
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: lorax-38.4-1.fc38 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-12-12 22:28:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Elia F 2022-12-07 16:59:58 UTC 
Description of problem:
When booting a Fedora 37 or Rawhide cd made with mkksiso, 

Version-Release number of selected component (if applicable):
38.3

How reproducible:
`mkksiso --ks ks.cfg input.iso output.iso`

Steps to Reproduce:
1. Using a validated, flattened kickstart, make an iso image with mkksiso
2. Press "e" at the Grub entry to view the cmdline entries

Actual results:

No "inst.ks=ks.cfg" entry in the grub boot entries.

Expected results:

Expected "inst.ks=/ks.cfg" in the grub boot entry

Additional info:
Comment 1 Elia F 2022-12-07 17:01:47 UTC 
When booting an iso made with mkksiso, it behaves as a normal install cd without executing the kickstart.
Comment 2 Elia F 2022-12-07 17:47:32 UTC 
Upon some further investigation:

mkksiso does indeed change the grub.cfg config file. However, the iso will not show the "inst.ks" grub cmdline option that was added in the grub menu.
Comment 3 Brian Lane 2022-12-07 19:08:24 UTC 
What kind of system are you booting this on? And are you booting an actual iso, or have you written the image to a usb flash drive?
Comment 4 Elia F 2022-12-07 19:20:28 UTC 
So the system is a Dell Latitude 5420. In my testing I flashed the ISO to a flash drive.
Comment 5 Brian Lane 2022-12-08 19:13:01 UTC 
Ends up this is totally my fault. For UEFI booting from a hda device it needs to update the efiboot.img that's embedded in the iso. Somehow I missed that in my testing and thought I could stop doing that. So I'll have to add that back, which is also going to mean that it needs to be run as root again :/
Comment 6 Brian Lane 2022-12-09 00:27:20 UTC 
PR here - https://github.com/weldr/lorax/pull/1290