Bug 2152132

Summary: lbzip2: Calls undeclared xalloc_die function in unbundled gnulib code
Product: [Fedora] Fedora Reporter: Florian Weimer <fweimer>
Component: lbzip2Assignee: Florian Weimer <fweimer>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: dominik, epel-packagers-sig, lzap, michel, mizdebsk
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: lbzip2-2.5-25.20171011gitb6dc48a.fc38 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-01-05 17:17:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2137512    

Description Florian Weimer 2022-12-09 12:03:33 UTC
This package copies xalloc.c from gnulib and builds it in such a way that it triggers an implicit function declaration warning:

make[3]: Entering directory '/builddir/build/BUILD/lbzip2-b6dc48a7b9bfe6b340ed1f6d72133608ad57144b/lib'
gcc -DHAVE_CONFIG_H -I.     -Wno-cast-qual -Wno-conversion -Wno-float-equal -Wno-sign-compare -Wno-undef -Wno-unused-function -Wno-unused-parameter -Wno-float-conversion -Wimplicit-fallthrough -Wno-pedantic -Wno-sign-conversion -Wno-type-limits -Wno-unsuffixed-float-constants -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64  -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -c -o libgnu_a-xmalloc.o `test -f 'xmalloc.c' || echo './'`xmalloc.c
make[3]: Leaving directory '/builddir/build/BUILD/lbzip2-b6dc48a7b9bfe6b340ed1f6d72133608ad57144b/lib'
xmalloc.c: In function 'nonnull':
xmalloc.c:35:5: warning: implicit declaration of function 'xalloc_die' [-Wimplicit-function-declaration]
   35 |     xalloc_die ();
      |     ^~~~~~~~~~

I have raised this issue on the gnulib list:

  xmalloc calling undeclared xalloc_die function
  <https://lists.gnu.org/archive/html/bug-gnulib/2022-12/msg00036.html>

This is a blocker for building lbzip2 in stricter C99 mode.