Bug 2152414
| Summary: | Xorg server does not correctly select the DCP for the display without a quirk | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Leif Liddy <leif.liddy> |
| Component: | xorg-x11-server | Assignee: | Adam Jackson <ajax> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 37 | CC: | ajax, asahi-sig, bskeggs, davide, ecurtin, jglisse, marcan, ngompa13, ofourdan, rhughes, rstrode, sandmann, xgl-maint |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | aarch64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | xorg-x11-server-1.20.14-15.fc37 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-01-17 01:36:20 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Leif Liddy
2022-12-11 17:27:32 UTC
(In reply to Leif Liddy from comment #0) > Description of problem: > This issue affects > 1. Apple Silicon devices M1/M2 systems > 2. running Xorg > 3. running the latest Asahi kernel > https://github.com/AsahiLinux/linux/releases/tag/asahi-6.1-rc8-3 > 4. and the latest mesa drivers https://gitlab.freedesktop.org/asahi/mesa/-/tree/fixes/20221209 So that means the issue cannot occur with the standard kernel and Mesa which ship with Fedora? If that's the case, what is the point of changing the configuration unless we actually add support for that hardware in Fedora itself? > If that's the case, what is the point of changing the configuration unless we actually add support for that hardware in Fedora itself? The Asahi SIG (https://fedoraproject.org/wiki/SIGs/Asahi) is in the process of doing precisely that. The approach we're taking is to upstream support into Fedora as much as possible (e.g. with m1n1, xkeyboard-config, etc.), and at the same time keep a handful of downstream components in copr for ease of development (as e.g. not all mesa changes are suitable for upstreaming at this time, but they will in the near to medium future) and for use in an upcoming Fedora Remix. In this case, the quirk shouldn't have any side effects, and it's a small enough change that IMO it makes sense to fix it directly in the Fedora package. Yup, as Davide said, we have been enabling support for this hardware in Fedora (https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1974). All of this will be eventually upstreamed and enabled in Fedora. This self-contained quirk fix would be one less package we have to fork in Fedora Asahi, the main two packages we fork at present are the kernel and mesa. Thanks for the explanation! I wonder if it would be wiser to actually submit that upstream directly (https://gitlab.freedesktop.org/xorg/xserver/-/blob/master/config/10-quirks.conf) and backport the change downstream in Fedora. Good idea! I'm gonna submit that now Upstream MR submitted: https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1021 Looks like the upstream merge request was accepted, so can we get this backported into Fedora's package now? (In reply to Neal Gompa from comment #7) > Looks like the upstream merge request was accepted, so can we get this > backported into Fedora's package now? Ideally, https://src.fedoraproject.org/rpms/xorg-x11-server/pull-request/11 would need to be updated accordingly, i.e.: 1/ Cherry-pick the fix from master in xserver upstream 2/ Add and apply the patch to the xorg-x11-server package I screwed that last PR up trying to rebase it. Here's a new one: https://src.fedoraproject.org/rpms/xorg-x11-server/pull-request/13 Merged in rawhide and built. https://bodhi.fedoraproject.org/updates/FEDORA-2023-5a74a2c134 Can we also get this for F37 too? Yup, I just submitted a PR for that. https://src.fedoraproject.org/rpms/xorg-x11-server/pull-request/14 (In reply to Leif Liddy from comment #12) > Yup, I just submitted a PR for that. > https://src.fedoraproject.org/rpms/xorg-x11-server/pull-request/14 Thanks! However I shall close the PR, it is not needed anymore as I have merged the rawhide branch into the f37 branch, so that we don't have diverging branches. (FTR, in case someone wonders, it was safe to merge rawhide because @whot wrapped the byteswap patch meant for Fedora 38 into a "if %{fedora}Â >= 38") The build is here: https://koji.fedoraproject.org/koji/taskinfo?taskID=96206626 FEDORA-2023-c7dc682a77 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c7dc682a77 FEDORA-2023-c7dc682a77 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. |