Bug 2152550

Summary: bsd-games: Call to undeclared sigpause function in hunt/hunt/otto.c
Product: [Fedora] Fedora Reporter: Florian Weimer <fweimer>
Component: bsd-gamesAssignee: Florian Weimer <fweimer>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 38CC: jeff, sergio, wart
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: bsd-games-2.17-71.fc38 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-04-27 21:37:39 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2141798    
Attachments:
Description Flags
bsd-games-c99.patch none

Description Florian Weimer 2022-12-12 10:30:51 UTC
There is a minor C99 compatibility issue in this package.

hunt/hunt/otto.c:181:9: error: implicit declaration of function 'sigpause'
  181 |         sigpause(old_mask);
      |         ^~~~~~~~

I believe this is a glibc header file bug: there really should be a declaration for BSD-style sigpause by default. This bug is just a reminder that bsd-games needs to be inspected again once the glibc headers are fixed. And there does not seem to be an upstream bug tracker.

I should be able to post a glibc patch shortly.

Comment 1 Florian Weimer 2023-02-05 17:03:54 UTC
The sigpause function called here is the BSD version. I do not see a way to get BSD sigpause declared with the glibc headers today, and this is not going to change. Given the semantic variance, it does not sense to declare sigpause by default, and this package should be fixed with a patch.

Comment 2 Florian Weimer 2023-02-05 17:09:37 UTC
Created attachment 1942366 [details]
bsd-games-c99.patch

Comment 3 Ben Cotton 2023-02-07 15:11:39 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 38 development cycle.
Changing version to 38.