Bug 2153741

Summary: [fwcfg 32bit support] osinfo-db does not know about the "fwcfg" virtio-win driver
Product: Red Hat Enterprise Linux 9 Reporter: Laszlo Ersek <lersek>
Component: virtio-winAssignee: Vadim Rozenfeld <vrozenfe>
virtio-win sub component: distribution QA Contact: leidwang <leidwang>
Status: CLOSED ERRATA Docs Contact:
Severity: unspecified    
Priority: unspecified CC: coli, jinzhao, juzhang, tpelka, victortoso, vrozenfe, ymankad
Version: unspecifiedKeywords: Reopened, RFE, Triaged
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-05-09 07:55:12 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1983947    
Bug Blocks: 2151752    

Description Laszlo Ersek 2022-12-15 10:34:32 UTC
Upstream osinfo-db @ 72c69622e6db does not know about the "fwcfg" virtio-win driver, only about the "qemufwcfg" driver. These drivers are distinct (in fact they are mutually exclusive); the former is a functional driver while the latter is a stub driver. "virtio-win-1.9.30-0.el9_1.noarch" provides both drivers, but osinfo-db does not expose both, only "qemufwcfg".

The primary request is to fix this in upstream osinfo-db (i.e., expose "fwcfg").

If that's not the right thing to do, then we should move this BZ to virtio-win, so that the downstream virtio-win packaging expose the "fwcfg" driver, via its osinfo-db drop-in XMLs at "/usr/share/osinfo/os/microsoft.com/*".

Comment 1 Laszlo Ersek 2022-12-15 10:44:25 UTC
(Originally encountered under bug 2151752.)

Comment 2 Victor Toso 2022-12-15 13:16:07 UTC
Ok, should be a matter of extending the commit
https://gitlab.com/libosinfo/osinfo-db/-/commit/43913618247a70ed7727dcf24e5b560507ccaf20

Comment 3 Victor Toso 2022-12-19 19:35:31 UTC
Just a quick update. Current osinfo-db uses virtio-win from 2019 which does not have fwcfg in it [0]

[0] https://fedorapeople.org/groups/virt/unattended/drivers/preinst/virtio-win/0.1.171/w10/x86/

So, we need to unpack a new virtio-win release into fedorapeople.org/groups/virt/* and then update osinfo-db with new files per windows releases.

I plan to have this fixed for 9.2 so devel_ack+

Comment 4 Victor Toso 2023-01-09 09:27:35 UTC
Hi Laszlo,

Do you have an easy way to test installation of osinfo-db's windows drivers?

I got osinfo-db updated in osinfo-db!552 but I'm not sure what is the best way to test win 10 and win 11, only win 8.1

https://gitlab.com/libosinfo/osinfo-db/-/merge_requests/552

Comment 5 Laszlo Ersek 2023-01-09 11:43:36 UTC
Hi Victor,

thanks for the osinfo-db update.

The best (or at least "original") way for testing this would be for you to build a new RHEL-9 package (official development build, or just a scratch build), and then to hand that to the Virt-Tools QE team. They could repeat the virt-v2v conversions from bug 2151752, for the win2022, win11, win2019, win10 guests, and then we could verify from the conversion logs that virt-v2v located the drivers from "virtio-win-1.9.30-0.el9_1.noarch" based on the osinfo content.

For this, it would also be necessary that the new RHEL-9 osinfo-db package match the latest content of virtio-win in RHEL-9. (currently 1.9.30-0.el9_1, IIUC.)

Thanks!

Comment 10 Victor Toso 2023-01-10 09:16:45 UTC
The transition to fwcfg driver is not complete yet, so there is no point in updating osinfo-db for incomplete/unsupported drivers.

I still plan to update virtio-win references in osinfo-db upstream and in fedora. Any suggestions on how properly test them from osinfo-db or host-side installation of those drivers are very much welcomed!

Removing devel-ack, we should probably address this in 9.3.0.
Radek, I'm removing ITM/DTM just to be sure the bot would not nag us latter.

Comment 12 RHEL Program Management 2023-01-10 09:16:55 UTC
Development Management has reviewed and declined this request. You may appeal this decision by reopening this request.

Comment 17 Victor Toso 2023-01-11 06:33:50 UTC
Moving to virtio-win.

Comment 24 leidwang@redhat.com 2023-03-07 07:30:47 UTC
fwcfg driver can be installed/uninstalled by the new installer in virtio-win-1.9.33-0.el9_2,move the bz to verified.Thanks!

Comment 29 errata-xmlrpc 2023-05-09 07:55:12 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (virtio-win bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:2451