Bug 2155159
| Summary: | tin: C99 compatibility issues in the configure script | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Florian Weimer <fweimer> | ||||||
| Component: | tin | Assignee: | Florian Weimer <fweimer> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | adrian, dominik | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | tin-2.6.1-5.fc38 | Doc Type: | If docs needed, set a value | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2022-12-20 09:03:59 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 2141798 | ||||||||
| Attachments: |
|
||||||||
Thanks for the patch, but I don't see what errors or warning it's fixing and you're not mentioning any explicitly. Also, it doesn't apply against the newly released 2.6.2 sources, so unless you can provide the list of errors or warnings that this patch is fixing, I'm going to drop it. (In reply to Dominik 'Rathann' Mierzejewski from comment #1) > Thanks for the patch, but I don't see what errors or warning it's fixing and > you're not mentioning any explicitly. The additional prototypes fix implicit function declaration warnings. They are not visible because autoconf suppresses them. > Also, it doesn't apply against the > newly released 2.6.2 sources, so unless you can provide the list of errors > or warnings that this patch is fixing, I'm going to drop it. I believe this upstream commit: revno: 700 tags: 2.6.2 committer: Urs Janssen <urs> branch nick: tin-2.6.2 timestamp: Sun 2022-12-25 00:09:23 +0100 message: 2.6.2 release includes a variant of the patch I sent in. So it should be okay to drop the downstream patch. There will be at least another rebuild with an instrumented compiler. Oh, I see you've already updated to 2.6.2. I can confirm that the patch is no longer needed. Shall I drop it? Yes, I did update because I wanted to test the new NNTPS support. No need for action, thanks. I've actually re-used your patch name to fix a couple of other C99-related issues mentioned on your Change page, like implicit int<->pointer conversion. Thanks for sending your patch upstream! Created attachment 2004462 [details]
Patch with further compatibility fixes
I've also submitted it to tin-bugs.
|
Created attachment 1933725 [details] tin-configure-c99.patch There are a few missing #include directives in the configure script. I tried to re-generate the script using autoreconf 2.71, but the result does not appear to work. So I patched the configure script by hand to incorporate the necessary changes from the source files. Filing this here because upstream does not seem to have a public bug tracker.