Bug 2155325

Summary: Review Request: rust-smartstring - Compact inlined strings
Product: [Fedora] Fedora Reporter: Michel Lind <michel>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-01-04 01:24:03 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2155327    

Description Michel Lind 2022-12-20 20:25:59 UTC
Spec URL: https://salimma.fedorapeople.org/rust-smartstring.spec
SRPM URL: https://salimma.fedorapeople.org/rust-smartstring-1.0.1-1.fc37.src.rpm

Description:
Compact inlined strings.

Fedora Account System Username: salimma

Comment 1 Michel Lind 2022-12-20 22:32:41 UTC
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=95572567

Comment 2 Fabio Valentini 2022-12-21 16:06:37 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MPL-2.0+) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

You might want to add a comment as to why you're removing the criterion dev-dependency, like here:
https://src.fedoraproject.org/rpms/rust-unicode-xid/blob/rawhide/f/rust-unicode-xid.spec#_16

Comment 3 Michel Lind 2022-12-21 17:25:24 UTC
Thanks!

Will add the comment when importing

❯ fedpkg request-repo rust-smartstring 2155325
https://pagure.io/releng/fedora-scm-requests/issue/49952

❯ fedpkg request-branch --repo rust-smartstring --all-releases
https://pagure.io/releng/fedora-scm-requests/issue/49953
https://pagure.io/releng/fedora-scm-requests/issue/49954

❯ fedpkg request-branch --repo rust-smartstring epel9
https://pagure.io/releng/fedora-scm-requests/issue/49955

Comment 4 Gwyn Ciesla 2022-12-21 17:30:38 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-smartstring

Comment 5 Fedora Update System 2023-01-03 00:27:22 UTC
FEDORA-EPEL-2023-ae11e26767 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-ae11e26767

Comment 6 Fedora Update System 2023-01-03 03:54:52 UTC
FEDORA-2023-815ee95850 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-815ee95850

Comment 7 Fedora Update System 2023-01-03 03:59:56 UTC
FEDORA-2023-74ed908696 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-74ed908696

Comment 8 Fedora Update System 2023-01-04 01:24:03 UTC
FEDORA-2023-74ed908696 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2023-01-04 01:32:30 UTC
FEDORA-2023-815ee95850 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2023-01-04 02:18:44 UTC
FEDORA-EPEL-2023-ae11e26767 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-ae11e26767

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2023-01-05 01:46:28 UTC
FEDORA-EPEL-2023-ae11e26767 has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.