Bug 2156397

Created attachment 1934525 [details]
Patch to remove need for -fcommon

Description of problem:
bristol currently fails to build: 
https://koji.fedoraproject.org/koji/buildinfo?buildID=2007040

Version-Release number of selected component (if applicable):
bristol-0.60.11-19.fc36.src.rpm

(Note this also is the root cause of Bug 2116055 )

How reproducible:
run rpmbuild on spec.

Steps to Reproduce:
1. Install fedora 37
2. rpmbuild -rb bristol-0.60.11-19.fc36.src.rpm

Actual results:
...
checking for suffix of executables... 
checking whether we are cross compiling... configure: error: in `/home/jjc/rpmbuild/BUILD/bristol-0.60.11':
configure: error: cannot run C compiled programs.
If you meant to cross compile, use `--host'.
See `config.log' for more details
error: Bad exit status from /var/tmp/rpm-tmp.fapy0b (%build)

RPM build warnings:
    user mockbuild does not exist - using root
    user mockbuild does not exist - using root
    user mockbuild does not exist - using root
    user mockbuild does not exist - using root
    user mockbuild does not exist - using root

RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.fapy0b (%build)


Expected results:
The rpm to build.

Additional info:
Investigation revealed that the problem is that bristol is using the legacy -fcommon option, which caused the configure to fail.

This can be fixed by removing the need for -fcommon with the attached patches and modifying the spec with:

--- bristol.spec	2021-08-30 05:55:25.000000000 -0600
+++ bristol_new.spec	2022-12-26 12:25:32.456339756 -0700
@@ -9,6 +9,7 @@
 Source1:    %{name}.desktop
 Patch0:     bristol-0.60.9-CVE-2010-3351.patch
 Patch1:     bristol-0.60.11-fix-build-with-alsa.patch
+Patch2:     bristol-0.60.11-fix-common.patch
 
 BuildRequires: gcc autoconf automake libtool
 BuildRequires: libX11-devel alsa-lib-devel jack-audio-connection-kit-devel desktop-file-utils
@@ -47,7 +48,7 @@
 
 %build
 autoreconf -if
-CFLAGS="-fcommon" ./configure --prefix=%{_prefix} --libdir=%{_libdir} --enable-static=no --disable-version-check
+./configure --prefix=%{_prefix} --libdir=%{_libdir} --enable-static=no --disable-version-check
 sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' libtool
 sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool