Bug 2156509

Summary: Actually compiled without enable dedupe for BTRFS
Product: [Fedora] Fedora Reporter: lnx <lovyagin>
Component: jdupesAssignee: David Cantrell <dcantrell>
Status: CLOSED ERRATA QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 37CC: dcantrell
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: jdupes-1.20.2-5.fc37 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-02-04 01:30:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description lnx 2022-12-27 07:36:10 UTC
Description of problem:

jdupes.spec states that the program should be compiled with dedupe support:

%make_build ENABLE_DEDUPE=1 

but it doesn't actually work.

How reproducible:


Steps to Reproduce:

1. Install, execute jdupes -B
2. Check jdupes --help | grep -- -B

Actual results:

The output is 

This program was built without dedupe support

jdupes --help | grep -- -B
outputs nothing

Expected results:

Dedupe should work

$ jdupes --help | grep -- -B
 -B --dedupe            do a copy-on-write (reflink/clone) deduplication
$ jdupes -B
no files or directories specified (use -h option for help)

Additional info:

Patching spec file by adding -DENABLE_DEBUPE compile flag fixes the problem

36c36
< %make_build ENABLE_DEDUPE=1 HARDEN=1 CFLAGS="%{optflags}" PREFIX="%{_prefix}" MAN_BASE_DIR="%{_mandir}"
---
> %make_build ENABLE_DEDUPE=1 HARDEN=1 CFLAGS="%{optflags} -DENABLE_DEDUPE" PREFIX="%{_prefix}" MAN_BASE_DIR="%{_mandir}"

Comment 1 Fedora Update System 2023-01-26 20:21:52 UTC
FEDORA-2023-a6f2c82617 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-a6f2c82617

Comment 2 Fedora Update System 2023-01-27 17:24:02 UTC
FEDORA-2023-a6f2c82617 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-a6f2c82617`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-a6f2c82617

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 3 Fedora Update System 2023-02-04 01:30:11 UTC
FEDORA-2023-a6f2c82617 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.