Bug 2156962

Summary: Review Request: rust-tree_magic_mini - Determines the MIME type of a file by traversing a filetype tree
Product: [Fedora] Fedora Reporter: Michel Lind <michel>
Component: Package ReviewAssignee: Davide Cavalca <davide>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: davide, decathorpe, package-review
Target Milestone: ---Flags: davide: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-01-08 01:20:12 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2158272    
Bug Blocks: 2156961    

Description Michel Lind 2022-12-29 22:46:01 UTC
Spec URL: https://salimma.fedorapeople.org/rust-tree_magic_mini.spec
SRPM URL: https://salimma.fedorapeople.org/rust-tree_magic_mini-3.0.3-1.fc37.src.rpm

Description:
Determines the MIME type of a file by traversing a filetype tree.

Fedora Account System Username: salimma

Comment 1 Davide Cavalca 2022-12-30 15:23:44 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 2 Michel Lind 2022-12-30 20:42:40 UTC
Thanks!

src/fedora/pkgs-sig-rust 
⬢ [fedora-toolbox:37] ❯ set -gx C tree_magic_mini

src/fedora/pkgs-sig-rust 
⬢ [fedora-toolbox:37] ❯ set -gx B 2156962

src/fedora/pkgs-sig-rust 
⬢ [fedora-toolbox:37] ❯ fedpkg request-repo rust-$C $B
https://pagure.io/releng/fedora-scm-requests/issue/50074

src/fedora/pkgs-sig-rust took 4s 
⬢ [fedora-toolbox:37] ❯ fedpkg request-branch --repo rust-$C --all-releases
https://pagure.io/releng/fedora-scm-requests/issue/50075
https://pagure.io/releng/fedora-scm-requests/issue/50076

src/fedora/pkgs-sig-rust took 7s 
⬢ [fedora-toolbox:37] ❯ fedpkg request-branch --repo rust-$C epel9
https://pagure.io/releng/fedora-scm-requests/issue/50077

Comment 3 Kevin Fenzi 2023-01-01 18:16:26 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-tree_magic_mini

Comment 4 Fabio Valentini 2023-01-01 19:38:13 UTC
> - package builds and installs without errors on rawhide

Have you actually checked this or did you only paste my review template?
One of the built packages fails to install with a missing dependency:

Error: 
 Problem 1: conflicting requests
  - nothing provides (crate(tree_magic_db/default) >= 3.0.0 with crate(tree_magic_db/default) < 4.0.0~) needed by rust-tree_magic_mini+tree_magic_db-devel-3.0.3-1.fc38.noarch
 Problem 2: package rust-tree_magic_mini+with-gpl-data-devel-3.0.3-1.fc38.noarch requires crate(tree_magic_mini/tree_magic_db) = 3.0.3, but none of the providers can be installed
  - conflicting requests
  - nothing provides (crate(tree_magic_db/default) >= 3.0.0 with crate(tree_magic_db/default) < 4.0.0~) needed by rust-tree_magic_mini+tree_magic_db-devel-3.0.3-1.fc38.noarch
(try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages)
WARNING: Failed install built packages


(i.e. the optional "with-gpl-data" feature depends on the tree_magic_db crate, which is not packaged)

Comment 5 Fedora Update System 2023-01-06 19:21:18 UTC
FEDORA-EPEL-2023-7c5c162f7e has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-7c5c162f7e

Comment 6 Fedora Update System 2023-01-07 01:28:43 UTC
FEDORA-EPEL-2023-7c5c162f7e has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-7c5c162f7e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2023-01-07 03:11:33 UTC
FEDORA-2023-4eaf0ab067 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-4eaf0ab067

Comment 8 Fedora Update System 2023-01-07 03:13:03 UTC
FEDORA-2023-3514393fb3 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-3514393fb3

Comment 9 Fedora Update System 2023-01-08 01:20:12 UTC
FEDORA-2023-4eaf0ab067 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2023-01-08 01:28:51 UTC
FEDORA-2023-3514393fb3 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2023-01-10 02:17:25 UTC
FEDORA-EPEL-2023-7c5c162f7e has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.