Bug 2158160

Summary: systemd-sysctl shouldn't log about write errors for keys prefixed with "-"
Product: Red Hat Enterprise Linux 8 Reporter: Michal Sekletar <msekleta>
Component: systemdAssignee: Michal Sekletar <msekleta>
Status: CLOSED ERRATA QA Contact: Frantisek Sumsal <fsumsal>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 8.7CC: jamacku, systemd-maint-list
Target Milestone: rcKeywords: Triaged
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: systemd-239-70.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-05-16 09:07:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2148578    

Description Michal Sekletar 2023-01-04 11:49:57 UTC 
Description of problem:
We backported support for "-" prefixed keys in sysctl.d snippets, however, we still warn about errors even for keys that are prefixed. We should ignore such errors and not print warning.

Version-Release number of selected component (if applicable):
systemd-239-69.el8.x86_64

How reproducible:
deterministic

Steps to Reproduce:
1.
cat >/tmp/sysctl-foo.conf <<"EOF"
kernel.foo = 1
EOF

cat >/tmp/sysctl-foo-ignore.conf <<"EOF"
-kernel.foo = 1
EOF

2. /usr/lib/systemd/systemd-sysctl /tmp/sysctl-foo.conf
3. /usr/lib/systemd/systemd-sysctl /tmp/sysctl-foo-ignore.conf

Actual results:
"Couldn't write '1' to 'kernel/foo', ignoring: No such file or directory" is printed in both cases.

Expected results:
Error message should be printed only after executing 2).

Additional info:
https://github.com/systemd/systemd/commit/32458cc9687c1b60ff0f22c0e71da93ce78b1534
Comment 2 Plumber Bot 2023-01-06 09:25:24 UTC 
fix merged to github main branch -> https://github.com/redhat-plumbers/systemd-rhel8/pull/348
Comment 9 errata-xmlrpc 2023-05-16 09:07:33 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (systemd bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:2985