Bug 2158524

Summary: [RFE] - Administer->Settings, On tab Autentication - Input field for 'Trusted hosts' not accepting multiple values
Product: Red Hat Satellite Reporter: visawant
Component: SettingsAssignee: Girija Soni <gisoni>
Status: CLOSED ERRATA QA Contact: Shweta Singh <shwsingh>
Severity: low Docs Contact:
Priority: unspecified    
Version: 6.13.0CC: addubey, apatel, bbuckingham, gisoni, lstejska, mhulan, nalfassi, rlavi, shwsingh
Target Milestone: 6.15.0Keywords: EasyFix, FutureFeature, Triaged, UserExperience
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-04-23 17:13:02 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description visawant 2023-01-05 16:14:27 UTC
Created attachment 1935959 [details]
Trusted hosts settings not accepting valid input values

Description of problem: Input field 'Trusted hosts' is not accepting multiple entries as per the description comma separated input should work.

Version-Release number of selected component (if applicable): 6.13.0 snap 4_0


How reproducible: Always


Steps to Reproduce:
1. Navigate to Administer -> Settings page, switch to tab 'Authentication'
2. Inside input filed of 'Trusted hosts' give multiple valid input comma separated as per maintained in Description.
3. Click submit button and observe error message.

Actual results: Not accepted valid input and showing error "must be comma separated, must contain valid hostnames"


Expected results: Input should accepted and display in list comma separated

Additional info: Attached screenshot related to same.

Comment 1 Brad Buckingham 2023-01-09 14:22:24 UTC
Is this a regression from previous release?

Thanks!

Comment 2 Marek Hulan 2023-01-09 14:29:06 UTC
I can not reproduce this on the most recent snap. Looking at your screenshot, I think you added a space after a comman. That makes the second host name " dhcp-3-85.vms...com" which is invalid (hostnames can't contain spaces. If that's the case, I'd recommend to close as not a bug.

Comment 5 Marek Hulan 2023-01-10 09:49:23 UTC
I don't think there's currently any validation like this, but I wonder whether it has changed with the recent backend reimplementation. I don't think it's bug though. I'd consider this more as a UX improvement so we start accepting spaces and trim them and will de-duplicate values.

Comment 7 nalfassi 2023-01-29 16:20:35 UTC
Created redmine issue https://projects.theforeman.org/issues/36017 from this bug

Comment 8 Bryan Kearney 2023-04-20 04:03:01 UTC
Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/36017 has been resolved.

Comment 10 Shweta Singh 2023-11-06 10:02:58 UTC
FailedQA

Version Tested: Satellite Stream Snap 35.0

Reason: We need some validation on the input string to check if valid hostname is added. Current fix is missing these validations on the string.

Comment 13 Shweta Singh 2023-11-21 05:40:49 UTC
Verified.

Version Tested: Satellite Stream Snap 35.0


Verification Steps:
1. Navigate to Administer -> Settings page, switch to tab 'Authentication'
2. Add multiple values in 'Trusted hosts' with comma separated as per mentioned in Description.

Results: Values are added as a comma separated list.

Comment 16 errata-xmlrpc 2024-04-23 17:13:02 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.15.0 release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2024:2010