Bug 2158627
| Summary: | default gpg-agent systemd service file: default option in file is deprecated | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christopher Klooz <py0xc3> |
| Component: | gnupg2 | Assignee: | Jakub Jelen <jjelen> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | 37 | CC: | bcl, crypto-team, jjelen, tm, tmz |
| Target Milestone: | --- | Keywords: | Triaged |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-08-07 14:53:26 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Christopher Klooz
2023-01-05 21:40:49 UTC
I filed https://dev.gnupg.org/T6336 upstream and attached a patch to remove the --supervised option from the example unit files. It may be sufficient to wait for that to be applied and then we can pick up the change on the next release. It makes sense to fix the issue upstream and wait for it. It is nothing time critical. But if we adopt it only for the next release and keep the file as it is on F37, we have to ensure that the option remains available throughout the F37 life cycle, or ensure that the option is ignored if it gets removed from gnupg during that time. I cannot say much about GnuPG'S plans and practices in this respect. Since the tickets are already linked: a question that might be considered upstream is if the option should be just removed, or replaced by other option(s) or adjustments (generally, the behavior of "--supervised" makes sense for such a systemd service imho). Also, I am not sure if the current socket-based startup could cause trouble if the option is just removed: so maybe the related socket file needs adjustments, too. Not sure about further implications. Sure. The upstream commit which marked them deprecated included no useful details about the problems caused (very unfortunately). If there are options which should be used instead, that's something the folks upstream will hopefully help in determining. Thanks for taking this to upstream. Commit related to https://dev.gnupg.org/T6336 -> https://dev.gnupg.org/rGeae28f1bd4a5632e8f8e85b7248d1c4d4a10a5ed I think it makes sense to switch to managing via /etc/gnupg/gpg.conf in the medium term (see commit). Out of curiosity, does anyone know what we'd put into /etc/gnupg/gpg.conf to provide similar functions as the systemd user units? Those unit files are gone in 2.4.1. I think our options are: * restore them via a patch (knowing they have race conditions and are unsupported upstream) * convert to global options in /etc/gnupg/gpg.conf (whatever that looks like) * drop support for the systemd units (which seems unlikely to be a good option for f38) My suggestion would be to update only Fedora 39/rawhide with 2.4.1 and drop the systemd units in there. If upstream can not maintain them, I do not have capacity nor experience to maintain them downstream only. If either of you have a use for these and would like to to step up to maintain them, patches are welcomed. Todd already filled a PR for the changes so I will merge & build these later today unless there would be some strong voices against: https://src.fedoraproject.org/rpms/gnupg2/pull-request/16 The systemd services were dropped as part of the above PR so closing this bug too. |