Bug 2158678
Summary: | Review Request: libcamera-apps - A small suite of libcamera-based apps | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Peter Robinson <pbrobinson> | ||||
Component: | Package Review | Assignee: | Javier Martinez Canillas <fmartine> | ||||
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | unspecified | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | rawhide | CC: | fmartine, package-review, pemensik | ||||
Target Milestone: | --- | Flags: | fmartine:
fedora-review+
|
||||
Target Release: | --- | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2023-02-01 09:28:33 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Peter Robinson
2023-01-06 04:20:46 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/5203603 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/frostyx/fedora-review-2158678-libcamera-apps/fedora-rawhide-x86_64/05203603-libcamera-apps/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service This package contains a lot of lib*.so shared libraries used by executables, which lack soname versions [1]. They are required by packaging guidelines. Those libraries are used at link time as a normal library, not as plugins loaded runtime. rpms-unpacked/libcamera-apps-1.0.2-1.fc38.x86_64.rpm/usr/lib64/libcamera_app.so rpms-unpacked/libcamera-apps-1.0.2-1.fc38.x86_64.rpm/usr/lib64/libencoders.so rpms-unpacked/libcamera-apps-1.0.2-1.fc38.x86_64.rpm/usr/lib64/libimages.so rpms-unpacked/libcamera-apps-1.0.2-1.fc38.x86_64.rpm/usr/lib64/liboutputs.so rpms-unpacked/libcamera-apps-1.0.2-1.fc38.x86_64.rpm/usr/lib64/libpost_processing_stages.so rpms-unpacked/libcamera-apps-1.0.2-1.fc38.x86_64.rpm/usr/lib64/libpreview.so Such format is usually provided by *-devel subpackages, but this package does not have such thing. I think they are supposed to be internal for the program and they should be placed into %{_libdir}/%{name} with using rpath for this case [2]. It seems those libraries are not meant to be reused by any other tools directly, because no -devel headers allows linking to them. It seems those names do not conflicts with any existing packages now, but those names are not specialized enough. I think moving them to to application specific subdirectory is desireable to avoid future conflicts. [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_downstream_so_name_versioning [2] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_rpath_for_internal_libraries (In reply to Petr Menšík from comment #2) > This package contains a lot of lib*.so shared libraries used by executables, > which lack soname versions [1]. They are required by packaging guidelines. > Those libraries are used at link time as a normal library, not as plugins > loaded runtime. In some cases if the .so is a plugin and not a library it's not always the cases, there are numerous examples of this. > rpms-unpacked/libcamera-apps-1.0.2-1.fc38.x86_64.rpm/usr/lib64/libcamera_app. > so > rpms-unpacked/libcamera-apps-1.0.2-1.fc38.x86_64.rpm/usr/lib64/libencoders.so > rpms-unpacked/libcamera-apps-1.0.2-1.fc38.x86_64.rpm/usr/lib64/libimages.so > rpms-unpacked/libcamera-apps-1.0.2-1.fc38.x86_64.rpm/usr/lib64/liboutputs.so > rpms-unpacked/libcamera-apps-1.0.2-1.fc38.x86_64.rpm/usr/lib64/ > libpost_processing_stages.so > rpms-unpacked/libcamera-apps-1.0.2-1.fc38.x86_64.rpm/usr/lib64/libpreview.so We already have a fix posted for upstream: https://github.com/raspberrypi/libcamera-apps/pull/441 Updated: SPEC: https://pbrobinson.fedorapeople.org/libcamera-apps.spec SRPM: https://pbrobinson.fedorapeople.org/libcamera-apps-1.1.0-1.fc37.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/build/5252674 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2158678-libcamera-apps/fedora-rawhide-x86_64/05252674-libcamera-apps/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service SPEC: https://pbrobinson.fedorapeople.org/libcamera-apps.spec SRPM: https://pbrobinson.fedorapeople.org/libcamera-apps-1.1.1-1.fc37.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=96948309 All looks good to me now! The Pagure repository was created at https://src.fedoraproject.org/rpms/libcamera-apps Created attachment 1941486 [details]
The .spec file difference from Copr build 5252674 to 5385625
Copr build: https://copr.fedorainfracloud.org/coprs/build/5385625 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2158678-libcamera-apps/fedora-rawhide-x86_64/05385625-libcamera-apps/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service |