Bug 2158696

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=95791985

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5203801
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/frostyx/fedora-review-2158696-python-mathics-scanner/fedora-rawhide-x86_64/05203801-python-mathics-scanner/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

LGTM, APPROVED

Please ask upstream to include the license text and add a note to include it in a future release

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* GNU General Public
     License, Version 3". 38 files have unknown license. Detailed output of
     licensecheck in /home/michel/src/fedora/reviews/2158696-python-
     mathics-scanner/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 51200 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[!]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Cannot parse rpmlint output:


Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1

python3-mathics-scanner.noarch: W: summary-ended-with-dot Character Tables and Tokenizer for Mathics and the Wolfram Language.
python3-mathics-scanner.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/mathics_scanner/generate/build_tables.py 644 /usr/bin/env python3
python3-mathics-scanner.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/mathics_scanner/generate/rl_inputrc.py 644 /bin python3
python3-mathics-scanner.noarch: W: no-manual-page-for-binary mathics-generate-json-table
 1 packages and 0 specfiles checked; 2 errors, 2 warnings, 2 badness; has taken 0.0 s 



Source checksums
----------------
https://files.pythonhosted.org/packages/source/M/Mathics_Scanner/Mathics_Scanner-1.2.4.tar.gz :
  CHECKSUM(SHA256) this package     : 7b05939751aacea42f3fc4e7eb1ab111f9fe32bae827e89f46a50e04907b19ef
  CHECKSUM(SHA256) upstream package : 7b05939751aacea42f3fc4e7eb1ab111f9fe32bae827e89f46a50e04907b19ef


Requires
--------
python3-mathics-scanner (rpmlib, GLIBC filtered):
    /usr/bin/python3
    python(abi)
    python3.11dist(chardet)
    python3.11dist(click)
    python3.11dist(pyyaml)



Provides
--------
python3-mathics-scanner:
    python-mathics-scanner
    python3-mathics-scanner
    python3.11-mathics-scanner
    python3.11dist(mathics-scanner)
    python3dist(mathics-scanner)



Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -b 2158696
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, Python
Disabled plugins: Perl, fonts, R, PHP, Java, C/C++, SugarActivity, Ocaml, Haskell
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Thanks!

$ fedpkg request-repo python-mathics-scanner 2158696
https://pagure.io/releng/fedora-scm-requests/issue/50320
$ fedpkg request-branch --repo python-mathics-scanner f37
https://pagure.io/releng/fedora-scm-requests/issue/50321
$ fedpkg request-branch --repo python-mathics-scanner f36
https://pagure.io/releng/fedora-scm-requests/issue/50322

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-mathics-scanner

FEDORA-2023-a9781b9673 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-a9781b9673

FEDORA-2023-a9781b9673 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2023-fbb955dd0f has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-fbb955dd0f

FEDORA-2023-99c173ba9b has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-99c173ba9b

FEDORA-2023-fbb955dd0f has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2023-99c173ba9b has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.