Bug 2158824

Summary: /usr/lib/systemd/system/opendmarc.service:16: Unknown lvalue 'Umask' in section 'Service'
Product: [Fedora] Fedora EPEL Reporter: Jonathan Kamens <h1k6zn2m>
Component: opendmarcAssignee: Kevin Fenzi <kevin>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: epel8CC: abo, kevin, matt
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: opendmarc-1.4.2-8.el9 opendmarc-1.4.2-8.fc37 opendmarc-1.4.2-8.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-01-17 00:38:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jonathan Kamens 2023-01-06 17:18:39 UTC
Systemd reporting /usr/lib/systemd/system/opendmarc.service:16: Unknown lvalue 'Umask' in section 'Service'.
It should be "UMask", not "Umask". Note the capital "M".

Comment 1 Kevin Fenzi 2023-01-07 22:27:26 UTC
Adding Matt to CC here. :) 

Matt: looks like you broke this moving the service file back into the spec. 

Can you fix? Or would you like me to?

Comment 2 Kevin Fenzi 2023-01-07 22:27:40 UTC
Oh, also, would you like to co-maintain?

Comment 3 Fedora Update System 2023-01-08 00:49:05 UTC
FEDORA-EPEL-2023-f58f803b2d has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-f58f803b2d

Comment 4 Fedora Update System 2023-01-08 00:49:05 UTC
FEDORA-2023-fc3c495913 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-fc3c495913

Comment 5 Fedora Update System 2023-01-08 00:49:07 UTC
FEDORA-EPEL-2023-c03db7f80f has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-c03db7f80f

Comment 7 Matt Domsch 2023-01-08 12:34:20 UTC
Belay this. Turns out my testing system has an opendkim.service that doesn't match what's in the package, which is why I didn't catch the failure. I haven't been running the Protect* and ReadWritePaths lines either in testing, which I thought I had, so that could certainly lead to more breakage. I will revert those changes as well, which will effectively undo all this. My apologies, I should have realized when one commenter on the previous update asked about it.

Comment 8 Matt Domsch 2023-01-08 15:20:11 UTC
builds are up in koji that remove the extra systemd protection stuff that was introduced but not well tested due to my error. Kevin & Jonathan, please take a look at the tree now, and if it looks good to you, I'll push the bodhi updates.

As for the offer to co-maintain, I think it's time for me to get out of package maintenance all together. I don't do enough of it often enough to remain fresh and competent, as I've just proven. Time to pass that baton on to the next generation.

Comment 9 Jonathan Kamens 2023-01-08 17:55:00 UTC
I have installed the koji build and it seems fine so far.

Are these log messages which started showing up after the upgrade more fallout from the changes that you reverted?

Jan  8 06:49:42 jik4 opendmarc[1074958]: implicit authentication service: hostname-elided
Jan  8 06:49:43 jik4 opendmarc[1074958]: 308Bndvc1461969: SPF(mailfrom): ntlworld.com fail
Jan  8 06:49:43 jik4 sendmail[1461969]: 308Bndvc1461969: Milter insert (1): header: Authentication-Results: hostname-elided; spf=fail smtp.mailfrom=ntlworld.com
Jan  8 06:49:43 jik4 sendmail[1461976]: 308BnhM51461976: SYSERR(opendmarc): collect: Cannot write ./df308BnhM51461976 (bfcommit, uid=991, gid=51): Read-only file system
Jan  8 06:49:43 jik4 sendmail[1461976]: 308BnhM51461976: from=opendmarc, size=1599, class=0, nrcpts=1, relay=opendmarc@localhost
Jan  8 06:49:43 jik4 sendmail[1461976]: 308BnhM51461976:   0: fl=0x0, mode=10600: FIFO: dev=0/13, ino=135382969, nlink=1, u/gid=991/988, size=0
Jan  8 06:49:44 jik4 sendmail[1461976]: 308BnhM51461976:   1: fl=0x2, mode=140777: SOCK localhost->[[UNIX: /run/systemd/journal/stdout]]
Jan  8 06:49:44 jik4 sendmail[1461976]: 308BnhM51461976:   2: fl=0x2, mode=140777: SOCK localhost->[[UNIX: /run/systemd/journal/stdout]]
Jan  8 06:49:44 jik4 sendmail[1461976]: 308BnhM51461976:   3: fl=0x2, mode=140777: SOCK localhost->[[UNIX: /run/systemd/journal/dev-log]]
Jan  8 06:49:44 jik4 sendmail[1461976]: 308BnhM51461976:   4: fl=0x8001, mode=20666: CHR: dev=0/5, ino=5, nlink=1, u/gid=0/0, size=0
Jan  8 06:49:44 jik4 sendmail[1461976]: 308BnhM51461976: SYSERR(opendmarc): queueup: cannot create queue file ./qf308BnhM51461976, euid=991, fd=-1, fp=0x0: Read-only file system
Jan  8 06:49:44 jik4 opendmarc[1074958]: 308Bndvc1461969: pclose() exited with status 71
Jan  8 06:49:44 jik4 opendmarc[1074958]: 308Bndvc1461969: ntlworld.com fail

Comment 10 Matt Domsch 2023-01-08 18:03:31 UTC
Yes, There are even newer builds this morning to address these. My testing rig wasn't using the right systemd service file hence I missed these.  Please grab the 1.4.2-8 packages from Koji.

Comment 12 Jonathan Kamens 2023-01-08 18:13:06 UTC
Yeah, the -8 is what I installed. The errors above are from before I installed the updated builds. I just wanted to make sure they're fixed in the builds I installed, hence the question.

Comment 13 Matt Domsch 2023-01-08 18:17:04 UTC
ah, ok, yes, -8 should have fixed those, as it removes the extra protection lines that would cause those failures.

Comment 14 Fedora Update System 2023-01-08 18:29:29 UTC
FEDORA-EPEL-2023-b370113e3b has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-b370113e3b

Comment 15 Fedora Update System 2023-01-08 18:29:31 UTC
FEDORA-2023-e816c36889 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e816c36889

Comment 16 Fedora Update System 2023-01-09 01:13:28 UTC
FEDORA-2023-e816c36889 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-e816c36889`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-e816c36889

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2023-01-09 01:37:25 UTC
FEDORA-EPEL-2023-68a7dea3d3 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-68a7dea3d3

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 18 Fedora Update System 2023-01-09 01:42:58 UTC
FEDORA-EPEL-2023-b370113e3b has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-b370113e3b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 19 Jonathan Kamens 2023-01-10 17:17:22 UTC
I just got the "Read-only file system" error sequence shown above again with opendmarc-1.4.2-8.el8.x86_64. Please advise.

I am going to try doing a "systemctl daemon-reload" and then restarting opendmarc again just to make sure systemd is using the most recent unit file, but I'm not sure that's going to make a difference.

Comment 20 Fedora Update System 2023-01-17 00:38:29 UTC
FEDORA-EPEL-2023-68a7dea3d3 has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 21 Fedora Update System 2023-01-17 01:36:14 UTC
FEDORA-2023-e816c36889 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 22 Fedora Update System 2023-01-17 01:37:15 UTC
FEDORA-EPEL-2023-b370113e3b has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.