Bug 2159269

Summary: bib2html: C99 compatibility fixes
Product: [Fedora] Fedora Reporter: Florian Weimer <fweimer>
Component: bib2htmlAssignee: Florian Weimer <fweimer>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: terje.rosten
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: bib2html-1.2.1-34.fc38 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-01-11 12:16:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2141798    
Attachments:
Description Flags
bib2html-c99.patch none

Description Florian Weimer 2023-01-09 09:28:46 UTC
Created attachment 1936748 [details]
bib2html-c99.patch

In order to avoid build failures with future compilers, we need to add proper function prototypes to the generated parser and lexer. The sources already hint to this, but automake is generally quite poor at supporting this. What works in my experience is to add the required prototypes to some header file that is included everywhere (including the generated lexer/parser sources, so that the manually written declarations are checked against the implementation).

Tracking this here because upstream seems to be inactive.