Bug 2159522

Summary: Review Request: glab - A GitLab CLI tool bringing GitLab to your command line
Product: [Fedora] Fedora Reporter: Mikel Olasagasti Uranga <mikel>
Component: Package ReviewAssignee: Alejandro Sáez Morollón <asm>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: asm, package-review
Target Milestone: ---Flags: asm: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-02-08 19:00:18 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2159451    
Bug Blocks:    

Description Mikel Olasagasti Uranga 2023-01-09 22:30:47 UTC
Spec URL: https://mikel.olasagasti.info/tmp/fedora/glab.spec
SRPM URL: https://mikel.olasagasti.info/tmp/fedora/glab-1.24.1-1.fc37.src.rpm
Description: A GitLab CLI tool bringing GitLab to your command line.
Fedora Account System Username: mikelo2

Comment 1 Jakub Kadlčík 2023-01-09 22:34:09 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5209987
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2159522-glab/fedora-rawhide-x86_64/05209987-glab/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

Comment 2 Alejandro Sáez Morollón 2023-02-02 11:18:39 UTC
Looks like there's a missing dependency github.com/xanzy/go-gitlab, as you can see in the COPR build attached[0]

[0] https://copr.fedorainfracloud.org/coprs/alexsaezm/glab/build/5407242/

Comment 3 Alejandro Sáez Morollón 2023-02-02 11:26:13 UTC
I realized that the missing dependency is linked in the bug (2159451). Clearing needinfo flags

Comment 4 Alejandro Sáez Morollón 2023-02-06 04:55:13 UTC
This package uses go2rpm.

- [X] The specfile is sane.
- [X] License is correct
- [X] Builds successfully in mock
- [X] Package is installable (checked by fedora-review)
- [X] No relevant rpmlint errors
- [X] %check section passes
- [X] The latest version is packaged
- [X] `%goipath` is set correctly
- [X] Binaries don't conflict with binaries already in the distribution
- [X] The package complies with the Packaging Guidelines.

Approved. Please, remember to give privileges on the package to the Go SIG.

Comment 5 Fedora Admin user for bugzilla script actions 2023-02-08 18:40:27 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/glab

Comment 6 Fedora Update System 2023-02-08 18:59:22 UTC
FEDORA-2023-d466e0123d has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-d466e0123d

Comment 7 Fedora Update System 2023-02-08 19:00:18 UTC
FEDORA-2023-d466e0123d has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.