Bug 2159900

Summary:	[RFE] [Machines] Should show " Get a new RHSM token" after user click "Create and run" without token
Product:	Red Hat Enterprise Linux 9	Reporter:	Xianghua Chen <xchen>
Component:	cockpit-machines	Assignee:	Katerina Koukiou <kkoukiou>
Status:	CLOSED ERRATA	QA Contact:	Xianghua Chen <xchen>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	9.2	CC:	jvanderwaa, kkoukiou, mpitt, qzhang, wshi, ymao, yunyang
Target Milestone:	rc	Keywords:	FutureFeature, Triaged
Target Release:	---	Flags:	kkoukiou: needinfo+ pm-rhel: mirror+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	cockpit-machines-283-1.el9	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-05-09 07:34:17 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Xianghua Chen 2023-01-11 03:36:38 UTC

Description of problem:
[Machines] Migration failed with "operation failed: job 'migration out' unexpectedly failed"
 
Packages:
cockpit-machines-280-1.el9.noarch
cockpit-282-1.el9.x86_64
libvirt-dbus-1.4.1-5.el9.x86_64
libvirt-8.10.0-2.el9.x86_64
How reproducible:
100%

Steps:
1. Click "Create VM", 
Installation type: Download an OS
Operating System: Red Hat Enterprise Linux 9.2 (Plow)
Offline token: keep empty
2. Click "Create and run" without providing Offline token

Actual results:
There is an error under offline token:
Offline token must not be empty

Expected results:
There shoule be " Get a new RHSM token" under offline token too, otherwise user have to close the dialog and re-open it to see the link to get token.


Additional info:

Comment 2 Katerina Koukiou 2023-01-30 10:05:08 UTC

https://github.com/cockpit-project/cockpit-machines/pull/928

Comment 3 Xianghua Chen 2023-02-06 06:18:34 UTC

Hi Katerina, will we have this fix downstream this release? If yes, could you set the DTM&ITM so that it can get release+ flag for this bug?

Comment 8 Xianghua Chen 2023-02-16 05:44:36 UTC

Verified with packages:
cockpit-machines-283-1.el9.noarch
cockpit-285-1.el9.x86_64
libvirt-dbus-1.4.1-5.el9.x86_64
libvirt-daemon-9.0.0-3.el9.x86_64

Steps:
1. Click "Create VM", 
Installation type: Download an OS
Operating System: Red Hat Enterprise Linux 9.2 (Plow)
Offline token: keep empty

2. Click "Create and run" without providing Offline token
There will be error "Offline token must not be empty" and also "Get a new RHSM token. Then copy and paste it above." link to let user click to get the token.

So verified.

Comment 10 errata-xmlrpc 2023-05-09 07:34:17 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (cockpit-machines bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:2211