Bug 2159967

Summary: Add some validation for name in Simplified ACS creation via hammer
Product: Red Hat Satellite Reporter: Vladimír Sedmík <vsedmik>
Component: Alternate Content SourcesAssignee: Quinn James <qjames>
Status: CLOSED ERRATA QA Contact: David Moore <damoore>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.13.0CC: damoore, pcreech
Target Milestone: 6.13.0Keywords: Triaged
Target Release: Unused   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: rubygem-katello-4.7.0.11-1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-05-03 13:24:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Vladimír Sedmík 2023-01-11 08:59:20 UTC
Description of problem:
Not providing a name on Simplified ACS creation via hammer shows an unsightly error. Please consider adding some validation and message like 'Missing values for alternate_content_source.'


Version-Release number of selected component (if applicable):
6.13.0 snap 5


How reproducible:
always


Steps to Reproduce:
1. Try to create a simplified ACS, not providing name for it:
# hammer alternate-content-source create --alternate-content-source-type simplified


Actual results:
Could not create the Alternate Content Source.:
  PG::NotNullViolation: ERROR:  null value in column "name" violates not-null constraint
  DETAIL:  Failing row contains (42, null, null, null, null, null, null, null, {}, yum, simplified, null, null, null, null).


Expected results:
Validation added and improved error message shown.

Comment 1 Quinn James 2023-02-03 15:12:41 UTC
Created redmine issue https://projects.theforeman.org/issues/36041 from this bug

Comment 2 Bryan Kearney 2023-02-08 20:03:20 UTC
Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/36041 has been resolved.

Comment 7 errata-xmlrpc 2023-05-03 13:24:04 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.13 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:2097