Bug 2160028

Summary:	backport vsock patches for RHEL-9.2
Product:	Red Hat Enterprise Linux 9	Reporter:	Stefano Garzarella <sgarzare>
Component:	kernel	Assignee:	Stefano Garzarella <sgarzare>
kernel sub component:	KVM	QA Contact:	Qinghua Cheng <qcheng>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	medium
Priority:	medium	CC:	boyang, coli, jinzhao, juzhang, ldu, nilal, qcheng, vgoyal, virt-maint, yacao
Version:	9.2	Keywords:	Triaged
Target Milestone:	rc
Target Release:	9.2
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	kernel-5.14.0-243.el9	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-05-09 08:11:33 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Stefano Garzarella 2023-01-11 11:22:13 UTC

This is a preliminary list of vsock patches we have in Linux 6.1-rc3 that we should backport into RHEL-9.2:

7a4efe182ca6 vhost/vsock: Fix error handling in vhost_vsock_init()
44aa5a6dba82 net: vmw_vsock: vmci: Check memcpy_from_msg()
466a85336fee vsock: fix possible infinite sleep in vsock_connectible_wait_data()
cf6ff0df0fd1 vsock: remove the unused 'wait' in vsock_connectible_recvmsg()
0e3f72931fc4 vhost/vsock: Use kvmalloc/kvfree for larger packets.
454e7b138436 vsock/vmci: fix repeated words in comments
b1346338fbae vsock_test: POLLIN + SO_RCVLOWAT test
e061aed99855 vmci/vsock: check SO_RCVLOWAT before wake up reader
39f1ed33a448 virtio/vsock: check SO_RCVLOWAT before wake up reader
f2fdcf67aceb vsock: add API call for data ready
ee0b3843a269 vsock: pass sock_rcvlowat to notify_poll_in as target
a274f6ff3c5c vmci/vsock: use 'target' in notify_poll_in callback
e7a3266c9167 virtio/vsock: use 'target' in notify_poll_in callback
24764f8d3c31 hv_sock: disable SO_RCVLOWAT support
e38f22c860ed vsock: SO_RCVLOWAT transport set callback
a3e7b29e3085 vsock: Set socket state back to SS_UNCONNECTED in vsock_connect_timeout()
7e97cfed9929 vsock: Fix memory leak in vsock_connect()

They are more like fixes and a new feature (support for SO_RCVLOWAT).
vsock_test is updated to test this new feature.

Comment 3 Bo Yang 2023-01-16 10:52:12 UTC

Updated the result from Virt QE team - RHEL in ESXi.


Tested with 5.14.0-232.1869_744520832.el9 and passed the regression.


Test Environment
    Host: ESXi 7.0
    Guest: RHEL-9.2.0 with 5.14.0-232.1869_744520832.el9


Steps to Test
0. Upgraded the Guest with Repo URL based on above target Host.
1. Launched its regression with CI - https://ci-jenkins-csb-esxi.apps.ocp-c1.prod.psi.redhat.com/job/ESXi-Project/job/regression-trigger/31/, and checked cases status if failed.


If you have any specific cases or steps to try, let me know.

Comment 4 Qinghua Cheng 2023-01-20 14:04:51 UTC

Pre-verify on rhel 9.2

kernel:  5.14.0-232.1869_744520832.el9.x86_64
qemu-kvm: qemu-kvm-7.2.0-3.el9.x86_64

vsock regression test PASS.

Comment 9 Qinghua Cheng 2023-02-07 09:00:50 UTC

Verified on rhel 9.2

kernel: 5.14.0-252.el9.x86_64
qemu-kvm: qemu-kvm-7.2.0-6.el9.x86_64

Vsock automation tests PASS

SO_RCVLOWAT test case passes:

10 - SOCK_STREAM poll() + SO_RCVLOWAT...ok

Comment 11 errata-xmlrpc 2023-05-09 08:11:33 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: kernel security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:2458