Bug 2160035

Summary: gt: Build in C89 mode
Product: [Fedora] Fedora Reporter: Florian Weimer <fweimer>
Component: gtAssignee: Hans de Goede <hdegoede>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: hdegoede, kvolny
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: gt-0.4-38.fc38 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-01-11 11:59:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2137516    
Attachments:
Description Flags
gt-c99.patch
none
gt-configure-c99.patch none

Description Florian Weimer 2023-01-11 11:35:31 UTC
Created attachment 1937284 [details]
gt-c99.patch

I started porting the package to C99, but there are too many issues.

With the attached patch, the next slew of issues are:

dim.c:323: defaulting to int
dim.c:967: type defaults to int
dim.c:983: type defaults to int
dim.c:983: type defaults to int
dim.c:1014: type defaults to int
dim.c:951: type defaults to int
dim.c:853: type defaults to int
dim.c:951: type defaults to int
dim.c:678: type defaults to int
dim.c:678: type defaults to int
dim.c:669: type defaults to int
dim.c:1028: type defaults to int
dim.c:1044: type defaults to int
dim.c:1056: type defaults to int
dim.c:1056: type defaults to int
dim.c:1056: type defaults to int
dim.c:1028: type defaults to int
dim.c:1056: type defaults to int
dim.c:1044: type defaults to int
dim.c:1056: type defaults to int
dim.c:1044: type defaults to int
dim.c:1044: type defaults to int
dim.c:1064: type defaults to int
dim.c:669: type defaults to int
dim.c:662: type defaults to int
dim.c:397: type defaults to int
dim.c:422: type defaults to int
dim.c:422: type defaults to int
dim.c:422: type defaults to int
dim.c:397: type defaults to int
dim.c:352: implicit function declaration: initfuncs
dim.c:397: type defaults to int
dim.c:329: defaulting to int
dim.c:329: type defaults to int
dim.c:662: type defaults to int
dim.c:439: type defaults to int
dim.c:439: type defaults to int
dim.c:547: type defaults to int
dim.c:547: type defaults to int
dim.c:662: type defaults to int
dim.c:439: type defaults to int
dim.c:547: type defaults to int
dim.c:456: type defaults to int
dim.c:456: type defaults to int
dim.c:456: type defaults to int
dim.c:1103: defaulting to int

And I suspect it goes on after that.

Comment 1 Florian Weimer 2023-01-11 11:35:57 UTC
Created attachment 1937285 [details]
gt-configure-c99.patch