Bug 2160043
| Summary: | tkgate: Build in C89 mode | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Florian Weimer <fweimer> | ||||
| Component: | tkgate | Assignee: | Florian Weimer <fweimer> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | thibault | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | tkgate-2.0-38.beta10.fc38 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2023-01-11 12:12:15 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 2137516 | ||||||
| Attachments: |
|
||||||
Created attachment 1937299 [details] tkgate-c99.patch I tried to port the package to C99 mode, but failed because of internal type conflicts. With the attached patch, I get: In file included from tkgate.h:52, from paux.c:23: tkgate_config.h:32: note: this is the location of the previous definition 32 | #define STRMAX 1024 /* Maximum length of a string */ | paux.c:41:15: error: conflicting types for 'Encoder'; have 'void *' 41 | typedef void *Encoder; | ^~~~~~~ In file included from tkgate.h:53: tkgate_misc.h:47:28: note: previous declaration of 'Encoder' with type 'Encoder' {aka 'struct encoder_str'} 47 | typedef struct encoder_str Encoder; | ^~~~~~~ paux.c: In function 'ycString':