Bug 2160074
| Summary: | RFE: please consider using the GPT partition type IDs from the discoverable partitions spec | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daniel Berrangé <berrange> |
| Component: | anaconda | Assignee: | Anaconda Maintenance Team <anaconda-maint-list> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | anaconda-maint-list, bcl, berrange, blivet-maint-list, cglombek, crobinso, dlehman, extras-qa, g.kaviyarasu, jonathan, kraxel, lpoetter, maxim.suraev, vanmeeuwen+fedora, vponcova, vslavik, w |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1075288 | Environment: | |
| Last Closed: | 2023-10-17 14:21:43 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1075288 | ||
| Bug Blocks: | |||
|
Description
Daniel Berrangé
2023-01-11 13:36:50 UTC
On the blivet side, discoverable partitions is exposed as an opt-in feature, to be enabled using
from blivet.flags import flags
flags.gpt_discoverable_partitions = True
if that is done, then any PartitionDevice() object instance receiving a 'mountpoint' will lookup the corresponding GPT type ID and use that.
Regardless of that flag it is also possible for callers to manually specify a GPT partition type ID to several methods.
My inclination is to initially just make anaconda set flags.gpt_discoverable_partitions, possibly based on an anaconda.conf option similar to the approach for the "multipath_friendly_names" flags/option handling. This should make standardized GPT partition type IDs be set based on the uapi group spec "out of the box".
A question is whether there is unacceptable risk of regressions in doing that if people are relying on the traditional generic Linux partition type ID being set.
I'd also intend to extend pykickstart so it can accept a raw partition type ID for the 'part' command.
> A question is whether there is unacceptable risk of regressions in doing
> that if people are relying on the traditional generic Linux partition type
> ID being set.
Data point: I have several virtual machines with type being using
fdisk (or sfdisk in %post script). I have not noticed any problems
so far.
Related: in case the root filesystem is btrfs the default subvolume should be set to the "root" subvolume. This is actually a duplicate of bug 2178043, which has other discussion. Not sure which we want to keep more, to be honest. *** This bug has been marked as a duplicate of bug 2178043 *** |