Bug 2160103

Summary:	Duplicated group-forward-mask and group-fwd-mask in output of a linux bridge
Product:	Red Hat Enterprise Linux 9	Reporter:	Mingyu Shi <mshi>
Component:	nmstate	Assignee:	Gris Ge <fge>
Status:	CLOSED ERRATA	QA Contact:	Mingyu Shi <mshi>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	9.2	CC:	ferferna, jiji, jishi, network-qe, sfaye, till
Target Milestone:	rc	Keywords:	Regression, Triaged
Target Release:	---	Flags:	pm-rhel: mirror+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	nmstate-2.2.4-1.el9	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-05-09 07:31:53 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Mingyu Shi 2023-01-11 14:45:19 UTC

Description of problem:
In output of `nmstatectl show`, there are two duplicated options:
group-forward-mask
group-fwd-mask

They are one thing, the latter doesn't show on nmstate of rhel 8 and rhel 9.1.


Version-Release number of selected component (if applicable):
nmstate-2.2.3-2.el9.x86_64
nispor-1.2.9-1.el9.x86_64
NetworkManager-1.41.7-2.el9.x86_64
DISTRO=RHEL-9.2.0-20230102.0

How reproducible:
100%

Steps to Reproduce:
echo "
interfaces:
- name: br_test1
  type: linux-bridge
  state: up
" | nmstatectl apply
nmstatectl show br_test1 | grep group
nmstatectl show br_test1 | sed 's/group-forward-mask:.*/group-forward-mask: 16384/' | nmstatectl apply

Actual results:
NmstateError: VerificationError: Verification failure: br_test1.interface.bridge.options.group-forward-mask desire '16384', current '0'

Expected results: 
No failure, show only "group-forward-mask" in `nmstatectl show` ouput like before

Additional info:
If user mentions either "group-forward-mask" or "group-fwd-mask" in the desired state, it works fine. But when applying a full state roughly(like `nmstatectl show br_test1 | sed 's/group-forward-mask:.*/group-forward-mask: 16384/' | nmstatectl apply`), it is easy to ignore the rest option and get failed.

Comment 1 Gris Ge 2023-01-12 06:07:51 UTC

The `group-fwd-mask` is kernel option name used by CNV. The `group-forward-mask` is used by RHV and exists since version  1.0.

The `group-forward-mask` is just alias to `group-fwd-mask`.

User will get `ValueError` when desired different `group-fwd-mask` and `group-forward-mask`. For other valid case, they are all unified to `group-fwd-mask`.

Patch sent to upstream: https://github.com/nmstate/nmstate/pull/2192

Comment 4 Mingyu Shi 2023-01-30 07:45:00 UTC

Verified with:
nmstate-2.2.5-1.el9.x86_64
nispor-1.2.9-1.el9.x86_64
NetworkManager-1.41.90-1.el9.x86_64
DISTRO=RHEL-9.2.0-20230127.12

Comment 6 errata-xmlrpc 2023-05-09 07:31:53 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (nmstate bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:2190