Bug 2160112

Summary: Add validations for Simplified ACS update via hammer
Product: Red Hat Satellite Reporter: Vladimír Sedmík <vsedmik>
Component: Alternate Content SourcesAssignee: Quinn James <qjames>
Status: CLOSED ERRATA QA Contact: Samir Jha <sajha>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.13.0CC: iballou, pcreech, sajha
Target Milestone: 6.13.0Keywords: Triaged
Target Release: Unused   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: tfm-rubygem-katello-4.7.0.17-1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-05-03 13:24:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Vladimír Sedmík 2023-01-11 14:58:31 UTC
Description of problem:
Using hammer we are restricted to provide some particular arguments for Simplified ACS when we create one. However, we are not restricted to provide the same arguments when we update an existing Simplified ACS. 

In particular, the arguments and validations are:
                        Validation on
Argument                Create  Update
--base-url              ok      X
--subpaths              ok      X
--verify-ssl            X       X
--ssl-ca-cert-id        ok      X
--ssl-client-cert-id    ok      X
--ssl-client-cert-id    ok      X
--upstream-password     ok      X
--upstream-username     ok      X

The purpose of this BZ is to add the validation where missing (see the X in the table above)


Version-Release number of selected component (if applicable):
6.13.0 snap 5


How reproducible:
always


Steps to Reproduce:
1. Have a Satellite with Simplified ACS created
2. Update the ACS using restricted args:
# hammer alternate-content-source update --id 56 --base-url "https://content.example.com/" --subpaths "yums/,files/" --verify-ssl true --ssl-ca-cert-id 1 --ssl-client-cert-id 1 --ssl-client-cert-id 1 --upstream-username "john" --upstream-password "strong"


Actual results:
Alternate Content Source updated.


Expected results:
Could not update the Alternate Content Source.:
  Validation failed: <argument> must be blank

Comment 1 Quinn James 2023-02-02 15:28:28 UTC
Created redmine issue https://projects.theforeman.org/issues/36038 from this bug

Comment 3 Bryan Kearney 2023-02-27 16:03:10 UTC
Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/36038 has been resolved.

Comment 4 Bryan Kearney 2023-02-27 16:03:20 UTC
Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/36038 has been resolved.

Comment 12 errata-xmlrpc 2023-05-03 13:24:04 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.13 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:2097