Bug 2160197

Summary: giac headers use undefined uchar type
Product: [Fedora] Fedora Reporter: Jerry James <loganjerry>
Component: giacAssignee: Antonio T. sagitter <trpost>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 38   
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-02-10 20:21:19 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jerry James 2023-01-11 17:58:43 UTC
Description of problem:
The latest update of giac has made sagemath fail to build, with errors like this:

INFO: gcc: sage/libs/gsl/array.c
/usr/include/giac/plot.h:842:12: error: ‘uchar’ was not declared in this scope; did you mean ‘u_char’?
  842 | void blend(uchar r1,uchar g1,uchar b1,uchar r2,uchar g2,uchar b2,double t,uchar &r,uchar &g,uchar &b);
      |            ^~~~~
      |            u_char
/usr/include/giac/plot.h:842:21: error: ‘uchar’ was not declared in this scope; did you mean ‘u_char’?
  842 | void blend(uchar r1,uchar g1,uchar b1,uchar r2,uchar g2,uchar b2,double t,uchar &r,uchar &g,uchar &b);
      |                     ^~~~~
      |                     u_char
/usr/include/giac/plot.h:842:30: error: ‘uchar’ was not declared in this scope; did you mean ‘u_char’?
  842 | void blend(uchar r1,uchar g1,uchar b1,uchar r2,uchar g2,uchar b2,double t,uchar &r,uchar &g,uchar &b);
      |                              ^~~~~
      |                              u_char

I see a definition of uchar in signalprocessing.h, but there is no such definition in plot.h.

Version-Release number of selected component (if applicable):
giac-1.9.0.35-1.fc38.x86_64

How reproducible:
Always

Steps to Reproduce:
1. Try to build sagemath in Rawhide
2.
3.

Actual results:
Errors due to a missing definition of uchar.

Expected results:
The headers should define the types they use.

Additional info:

Comment 1 Antonio T. sagitter 2023-01-11 21:22:13 UTC
Thank you.
Submitted to upstream: https://xcas.univ-grenoble-alpes.fr/forum/viewtopic.php?f=4&t=2845

Comment 2 Ben Cotton 2023-02-07 15:05:15 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 38 development cycle.
Changing version to 38.