Bug 2160217
| Summary: | lvm create kvdo module mismatches should return non zero | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 9 | Reporter: | Corey Marthaler <cmarthal> |
| Component: | lvm2 | Assignee: | Zdenek Kabelac <zkabelac> |
| lvm2 sub component: | VDO | QA Contact: | cluster-qe <cluster-qe> |
| Status: | VERIFIED --- | Docs Contact: | |
| Severity: | low | ||
| Priority: | medium | CC: | agk, awalsh, heinzm, jbrassow, mcsontos, prajnoha, zkabelac |
| Version: | 9.2 | Keywords: | Triaged |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | lvm2-2.03.21-1.el9 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | Bug | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Corey Marthaler
2023-01-11 19:52:46 UTC
I don't think this is intended to be redirected to me on account of the module rebuild requirements. I think what Corey is asking for, is that the lvm command handles and reports the error condition better. For example, if I run `lvconvert --yes --type vdo-pool -n vdo_lv -V 2T vdo_sanity/vdo_pool` and the module can't be loaded via modprobe... It should return an error like "Unable to load required kvdo kernel module" rather than a random modprobe failure output. Is that correct, corey? (In reply to Andy Walsh from comment #1) > I don't think this is intended to be redirected to me on account of the > module rebuild requirements. I think what Corey is asking for, is that the > lvm command handles and reports the error condition better. > > For example, if I run `lvconvert --yes --type vdo-pool -n vdo_lv -V 2T > vdo_sanity/vdo_pool` and the module can't be loaded via modprobe... It > should return an error like "Unable to load required kvdo kernel module" > rather than a random modprobe failure output. > > Is that correct, corey? Exactly. At a minimum, return non zero, better yet, a warning/error like mentioned in comment #1. Ahh right - I've originally got impression from the title it's been bug about missing kvdo module. Looking closer - yep lvconvert internally misinterpreted error handling path - fixed with this upstream patch: https://listman.redhat.com/archives/lvm-devel/2023-February/024616.html Few more similar issues were also fixed for Pool/RAID and Integrity conversion with this patch. With patch we now correctly return exit code 5. Marking Verified:Tested in the latest rpms. kernel-5.14.0-312.el9 BUILT: Thu May 11 08:04:19 PM CEST 2023 lvm2-2.03.21-1.el9 BUILT: Fri Apr 21 02:33:33 PM CEST 2023 lvm2-libs-2.03.21-1.el9 BUILT: Fri Apr 21 02:33:33 PM CEST 2023 [root@virt-521 ~]# lvcreate --yes --type vdo -n vdo_lv -L 25G vdo_sanity -V 2T modprobe: FATAL: Module kvdo not found in directory /lib/modules/5.14.0-312.el9.x86_64 /usr/sbin/modprobe failed: 1 vdo: Required device-mapper target(s) not detected in your kernel. Run `lvcreate --help' for more information. [root@virt-521 ~]# echo $? 3 Fixed in the latest build as well. Marking VERIFIED. kernel-5.14.0-312.el9 BUILT: Thu May 11 08:04:19 PM CEST 2023 lvm2-2.03.21-2.el9 BUILT: Thu May 25 12:03:04 AM CEST 2023 lvm2-libs-2.03.21-2.el9 BUILT: Thu May 25 12:03:04 AM CEST 2023 [root@virt-521 ~]# lvcreate --yes --type vdo -n vdo_lv -L 25G vdo_sanity -V 2T modprobe: FATAL: Module kvdo not found in directory /lib/modules/5.14.0-312.el9.x86_64 /usr/sbin/modprobe failed: 1 vdo: Required device-mapper target(s) not detected in your kernel. Run `lvcreate --help' for more information. [root@virt-521 ~]# echo $? 3 |