Bug 2160558

Summary: backport https://github.com/ostreedev/ostree/pull/2519/commits/cb731294837736e957ee595ce11ab115277dbb36 [rhel-8.4.0.z]
Product: Red Hat Enterprise Linux 8 Reporter: RHEL Program Management Team <pgm-rhel-tools>
Component: ostreeAssignee: RHCOS SST <rhcos-sst>
Status: CLOSED ERRATA QA Contact: RHCOS SST QE <rhcos-sst-qe>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: ---CC: aaradhak, arolivei, dornelas, hhei, walters
Target Milestone: rcKeywords: Triaged, ZStream
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ostree-2020.7-8.el8_4 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 2160075 Environment:
Last Closed: 2023-01-30 15:01:45 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2160075    
Bug Blocks:    

Comment 1 Colin Walters 2023-01-13 16:01:15 UTC
See the 8.6 bug for verification instructions https://bugzilla.redhat.com/show_bug.cgi?id=2160557#c4

Comment 5 HuijingHei 2023-01-16 13:28:54 UTC
Verify passed with ostree-2020.7-8.el8_4.x86_64 on rhcos-410.84.202301101745-0-qemu.x86_64.qcow2

1) Test with old ostree-2020.7-7.el8_4.x86_64 using strace, reboot and check the karg is not applied

a) Setup
# rpm -q ostree
ostree-2020.7-7.el8_4.x86_64
# rpm-ostree kargs --append=foo=bar
# systemctl edit ostree-finalize-staged.service, then add

[Service]
ExecStop=
ExecStop=strace --inject=sync:delay_exit=400s ostree admin finalize-staged

b) Reboot and check the karg is not applied
# systemctl reboot

[root@cosa-devsh ~]# cat /proc/cmdline | grep foo
[root@cosa-devsh ~]# rpm-ostree status
State: idle
Warning: failed to finalize previous deployment
         ostree-finalize-staged.service: Failed with result 'timeout'.
         check `journalctl -b -1 -u ostree-finalize-staged.service`
Deployments:
* ostree://889627fea5f3d151a85ffc5d34ebf8cd5c2cfd9946a510320c78d335044da0df
                   Version: 410.84.202301101745-0 (2023-01-10T17:48:52Z)

2) Upgrade to ostree-2020.7-8.el8_4.x86_64 with the same steps, reboot and check the karg is applied 
# rpm-ostree override replace ostree-2020.7-8.el8_4.x86_64.rpm ostree-grub2-2020.7-8.el8_4.x86_64.rpm ostree-libs-2020.7-8.el8_4.x86_64.rpm
# reboot

a) Setup
# rpm -q ostree
ostree-2020.7-8.el8_4.x86_64
# rpm-ostree kargs --append=foo=bar
# systemctl edit ostree-finalize-staged.service, then add

[Service]
ExecStop=
ExecStop=strace --inject=sync:delay_exit=400s ostree admin finalize-staged

b) Reboot and check the karg is applied
# systemctl reboot

[root@cosa-devsh ~]# cat /proc/cmdline | grep foo
BOOT_IMAGE=(hd0,gpt3)/ostree/rhcos-204f0f49e8c85885831667cc4819c687528703a4a9344100ed1c26189bf6a115/vmlinuz-4.18.0-305.72.1.el8_4.x86_64 random.trust_cpu=on console=tty0 console=ttyS0,115200n8 ignition.platform.id=qemu ostree=/ostree/boot.1/rhcos/204f0f49e8c85885831667cc4819c687528703a4a9344100ed1c26189bf6a115/0 root=UUID=0ec148f9-af0e-44f8-801a-adfd69260e0a rw rootflags=prjquota boot=UUID=32973ab8-c607-477c-a976-f670863a318d foo=bar

Comment 11 errata-xmlrpc 2023-01-30 15:01:45 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (ostree bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:0505