Bug 2161300

Summary:	pack: Update -D_FORTIFY_SOURCE to use %_fortify_level
Product:	[Fedora] Fedora	Reporter:	Siddhesh Poyarekar <sipoyare>
Component:	pack	Assignee:	Lokesh Mandvekar <lsm5>
Status:	CLOSED ERRATA	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	38	CC:	go-sig, jnovy, lsm5, rh.container.bot, santiago
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	pack-0.29.0~rc1-1.fc38 pack-0.29.0~rc1-1.fc37	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-03-13 00:16:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2158232

Description Siddhesh Poyarekar 2023-01-16 14:59:41 UTC

Description of problem:
The CFLAGS hard code the fortification level to 2, use the %_fortify_level macro instead, see "Fortification level" in the build flags guide:

https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/rawhide/f/buildflags.md#source-fortification

This way, fortification will follow the default level chosen for the distribution.

Comment 1 Ben Cotton 2023-02-07 15:05:38 UTC

This bug appears to have been reported against 'rawhide' during the Fedora Linux 38 development cycle.
Changing version to 38.

Comment 2 Fedora Update System 2023-03-07 11:06:06 UTC

FEDORA-2023-b6223df82b has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-b6223df82b

Comment 3 Lokesh Mandvekar 2023-03-07 11:07:21 UTC

Hi Siddhesh, PTAL https://src.fedoraproject.org/rpms/pack/c/836366216d5c0f17ded208f11cd20baff35a2d3f?branch=rawhide . If that's not right, could you please send a PR? I can do new builds if required.

Comment 4 Fedora Update System 2023-03-07 11:08:00 UTC

FEDORA-2023-c4fee6cc2d has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c4fee6cc2d

Comment 5 Siddhesh Poyarekar 2023-03-07 13:56:04 UTC

(In reply to Lokesh Mandvekar from comment #3)
> Hi Siddhesh, PTAL
> https://src.fedoraproject.org/rpms/pack/c/
> 836366216d5c0f17ded208f11cd20baff35a2d3f?branch=rawhide . If that's not
> right, could you please send a PR? I can do new builds if required.

Oh you ended up dropping the _FORTIFY_SOURCE CFLAGS override with:

commit 504e168c67ad4b28f11d25b151458fd118979fae
Author: Lokesh Mandvekar <lsm5>
Date:   Mon Mar 6 20:41:04 2023 +0530

    fix build flags specification
    
    Signed-off-by: Lokesh Mandvekar <lsm5>

so the _fortify_level change above is unnecessary and can be reverted.

Comment 6 Lokesh Mandvekar 2023-03-07 14:12:48 UTC

(In reply to Siddhesh Poyarekar from comment #5)
> (In reply to Lokesh Mandvekar from comment #3)
> > Hi Siddhesh, PTAL
> > https://src.fedoraproject.org/rpms/pack/c/
> > 836366216d5c0f17ded208f11cd20baff35a2d3f?branch=rawhide . If that's not
> > right, could you please send a PR? I can do new builds if required.
> 
> Oh you ended up dropping the _FORTIFY_SOURCE CFLAGS override with:
> 
> commit 504e168c67ad4b28f11d25b151458fd118979fae
> Author: Lokesh Mandvekar <lsm5>
> Date:   Mon Mar 6 20:41:04 2023 +0530
> 
>     fix build flags specification
>     
>     Signed-off-by: Lokesh Mandvekar <lsm5>
> 
> so the _fortify_level change above is unnecessary and can be reverted.

ack, I'll revert that, thanks!

Comment 7 Fedora Update System 2023-03-08 01:26:25 UTC

FEDORA-2023-c4fee6cc2d has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-c4fee6cc2d`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-c4fee6cc2d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2023-03-08 02:24:47 UTC

FEDORA-2023-b6223df82b has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-b6223df82b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2023-03-09 01:15:33 UTC

FEDORA-2023-2df9d60e4c has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-2df9d60e4c`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-2df9d60e4c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2023-03-09 01:29:48 UTC

FEDORA-2023-5eca6a8326 has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-5eca6a8326

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2023-03-13 00:16:59 UTC

FEDORA-2023-5eca6a8326 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2023-03-18 04:58:06 UTC

FEDORA-2023-2df9d60e4c has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.