Bug 2161870

Scratch build failed. Details below:

BuilderException: Build failed:
Command '['rpmbuild', '-D', '_sourcedir .', '-D', '_topdir .', '-bs', '/var/tmp/thn-ltivx9au/gtest.spec']' returned non-zero exit status 1.

StdOut:
error: Bad source: ./googletest-release-1.13.0.tar.gz: No such file or directory


Traceback:
  File "/usr/local/lib/python3.10/site-packages/hotness/use_cases/package_scratch_build_use_case.py", line 56, in build
    result = self.builder.build(request.package, request.opts)
  File "/usr/local/lib/python3.10/site-packages/hotness/builders/koji.py", line 188, in build
    raise BuilderException(

If you think this issue is caused by some bug in the-new-hotness, please report it on the-new-hotness issue tracker: https://github.com/fedora-infra/the-new-hotness/issues

Changes pushed to pagure:

 https://src.fedoraproject.org/rpms/gtest/c/dd8a4b0cc70de94c2bb388f722cdb0e116b036ee?branch=rawhide

Test build:

 https://koji.fedoraproject.org/koji/taskinfo?taskID=96302863

I appreciate that you have been keeping gtest up to date.

In the future, could you please follow the Updates Policy[1] regarding incompatible updates in Rawhide? This library offers no ABI stability, and thus each update, even a patch update, is an .so version bump.

Specifically, the policy requires:

- When a proposed update contains an ABI or API change: notify a week in advance both the devel list and maintainers directly (using the packagename-maintainers alias) whose packages depend on yours to rebuild or offer to do these rebuilds for them.

- Use a side-tag when dealing with mass builds of many packages, so they can land at the same time. See Rawhide Gating/Multi Builds.

Otherwise, every package with a runtime dependency on gtest or gmock fails to install every time this package is updated, e.g., bug 2164017.

There are a very large number of packages that BuildRequire gtest/gmock and whose maintainers should get a heads-up before this package is updated, but the packages that link gtest/gmock at runtime and will FTI on every .so version bump if not rebuilt are:

- ceph
- davix
- gfal2
- libcamera
- mir
- python-steps
- wlcs

[1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/#_rawhide

This is a somewhat more significant breaking change than usual, because the minimum supported C++ version has been raised. From bug 2164003:

> In file included from /usr/include/gtest/gtest-message.h:57,
>                  from /usr/include/gtest/gtest-assertion-result.h:46,
>                  from /usr/include/gtest/gtest.h:64,
>                  from /builddir/build/BUILD/STEPS-3.6.0/test/unit/cpp/test_point3d.cpp:8:
> /usr/include/gtest/internal/gtest-port.h:270:2: error: #error C++ versions less than C++14 are not supported.
>   270 | #error C++ versions less than C++14 are not supported.
>       |  ^~~~~

I’m not sure whether any other dependent packages are still building with old C++ language versions or not.

FEDORA-2023-5fade668c9 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-5fade668c9

FEDORA-2023-5fade668c9 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

(In reply to Ben Beasley from comment #4)
> I’m not sure whether any other dependent packages are still building with
> old C++ language versions or not.

Of the packages with runtime dependencies.

- davix is: https://src.fedoraproject.org/rpms/davix/pull-request/3
- gfal2 is:
- python-steps was: https://src.fedoraproject.org/rpms/python-steps/c/f80c4da80426052549b24c449f51dd7dcae74b42?branch=rawhide

There are probably other packages with BR’s on gtest that use old C++ language versions and will FTBFS.

Details on affected packages:

https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/LUA7ESDCTZEP7E4QHWXFT37UAEWG6MGS/

I have already fixed (at least by offering a PR) most of the incompatibilities. A few remain.