Bug 2162436
| Summary: | Heads up - upgrading python-packaging will break test_chroot_gpg_hashes | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tomáš Hrnčiar <thrnciar> |
| Component: | copr-backend | Assignee: | Copr Team <copr-team> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 38 | CC: | clime7, copr-team, jkadlcik, mhroncok, msuchy, praiskup |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-04-03 19:00:04 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2166942 | ||
|
Description
Tomáš Hrnčiar
2023-01-19 15:00:20 UTC
This only fails in the test because the chroot name is "rhel-rawhide-s390x".
The code itself is:
el_chroots = ["rhel", "epel", "centos", "oraclelinux"]
...
if parts[0] in el_chroots:
...
if version.parse(el_version) > version.parse("7"):
And all the actual EL chroots have numeric versions, so this will never attempt to parse "rawhide" in production.
However, to stay safe, the code should really try-version.parse-except now. Something like:
try:
el_version_ = version.parse(el_version)
except InvalidVersion:
return return "sha256" # or whatever action is appropriate
else:
if el_version_ > version.parse("7"):
...
Thank you very much for letting us know beforehand. PR: https://github.com/fedora-copr/copr/pull/2492/files This bug appears to have been reported against 'rawhide' during the Fedora Linux 38 development cycle. Changing version to 38. |