Bug 2162594

Summary: Review Request: rust-portable-atomic - Portable atomic types including support for 128-bit atomics, atomic float, etc
Product: [Fedora] Fedora Reporter: Michel Lind <michel>
Component: Package ReviewAssignee: Davide Cavalca <davide>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: davide, package-review
Target Milestone: ---Flags: davide: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-01-31 01:36:54 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2162593    
Bug Blocks:    

Description Michel Lind 2023-01-20 05:18:14 UTC
Spec URL: https://salimma.fedorapeople.org/rust-portable-atomic.spec
SRPM URL: https://salimma.fedorapeople.org/rust-portable-atomic-1.0.0-1.fc37.src.rpm

Description:
Portable atomic types including support for 128-bit atomics, atomic float, etc.

Fedora Account System Username: salimma

Comment 1 Jakub Kadlčík 2023-01-20 05:22:26 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5259632
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2162594-rust-portable-atomic/fedora-rawhide-x86_64/05259632-rust-portable-atomic/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

Comment 2 Davide Cavalca 2023-01-20 17:10:55 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 3 Fedora Update System 2023-01-26 18:16:31 UTC
FEDORA-2023-b3b3ea1046 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-b3b3ea1046

Comment 4 Fedora Update System 2023-01-26 22:07:52 UTC
FEDORA-2023-1a534db3c2 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-1a534db3c2

Comment 5 Fedora Update System 2023-01-27 08:47:58 UTC
FEDORA-2023-1a534db3c2 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-1a534db3c2`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-1a534db3c2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2023-01-27 17:23:52 UTC
FEDORA-2023-b3b3ea1046 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-b3b3ea1046`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-b3b3ea1046

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2023-01-31 01:36:54 UTC
FEDORA-2023-1a534db3c2 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2023-01-31 01:57:16 UTC
FEDORA-2023-b3b3ea1046 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.