Bug 216293
| Summary: | blktap does not build on ia64 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Aron Griffis <agriffis> | ||||||
| Component: | kernel-xen | Assignee: | Keiichiro Tokunaga <ktokunag> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | |||||||
| Severity: | high | Docs Contact: | |||||||
| Priority: | high | ||||||||
| Version: | 5.0 | CC: | clalance, dchapman, dzickus, jarod, lwang, riel, sakaia, xen-maint, yongkang.you | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | ia64 | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | RHBA-2007-0959 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2007-11-07 19:15:24 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Aron Griffis
2006-11-18 20:52:28 UTC
*** Bug 212315 has been marked as a duplicate of this bug. *** Note that attachment 141558 [details] should obsolete attachment 137553 [details] but I didn't have permissions to do that. This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux major release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Major release. This request is not yet committed for inclusion. Per discussion with Prarit and Aron, > Bug 212315/216293: blktap does not build on ia64 > > This is completely fixed upstream and is important for the tech > preview. I just need to post the patches ported to RHEL5. I will do > that ASAP. Should be an RC blocker. Aron please ACK for devel; QE please ACK/NAK as appropriate. Note that the patch in comment #2 is more complicated that others in this group. Affects drivers/xen/blktap/blktapmain.c and drivers/xen/blktap/xenbus.c. devel ACK I put this on rhkernel-list today so we should get some comments back about the common code mods. Created attachment 142795 [details] Updated blktap patch, as posted for internal review This patch obsoletes attachment 141558 [details]. If blktap is building/working on IA64, this should be closed. Well... First ia64 xen kernels have to actually be able to *boot*... :) (bug 241674 and bug 243312) ...still not building. With the config option flipped back on in the latest kernel (-29.el5): drivers/xen/blktap/blktapmain.c: In function 'fast_flush_area': drivers/xen/blktap/blktapmain.c:859: error: implicit declaration of function 'create_lookup_pte_addr' make[3]: *** [drivers/xen/blktap/blktapmain.o] Error 1 make[2]: *** [drivers/xen/blktap] Error 2 make[1]: *** [drivers/xen] Error 2 make: *** [drivers] Error 2 I've got the blktap module compiling now, but not behaving entirely. Though it could be something else actually causing my problems, so stay tuned. More info to come later tonight. Current patch was posted to rhkernel-list earlier tonight, and there's a slightly different version that made its way into the upstream xen-unstable hg tree: http://xenbits.xensource.com/xen-unstable.hg?cs=f56b7ade7068 Created attachment 157513 [details]
Further updated patch, actually builds *and* works! (at least mostly)
This is the version of the patch with which I'm actually able to use blktap to
access a disk image, install a guest with, etc. Only issue at the moment, so
far as I can tell, is top reporting some insane memory usage from tapdisk. Its
reporting figures several orders of magnitude greater than the amount of memory
in the system (its claiming to use 2000% of memory), but swap isn't being
abnormally used, no oom-kills, etc., so it may just be an accounting error of
some sort, since I can't see any other ill effects.
Guest install finished just fine, no more tapdisk process reporting gross memory usage once its shut down. More testing in the morning. Patch submitted for internal review. Updated patch including a one-line-of-code addition from fujitsu to eliminate the tapdisk memory issue posted for review. We still have one remaining problem with some dom0 console spew on domU bootup though: blk_tap: BLKTAP: READ request sector[8192002,16000], Total [8192000] blk_tap: BLKTAP: Sector request greaterthan size This happens on bootup within the initrd. After some initrd hacking (basically, adding a bunch of sleep calls between steps), I've determined that there are two distinct bursts of spew, one that coincides with "Creating root device." (aka mkrootdev -t ext3 ...) and one with "Mounting root filesystem." (aka mount /sysroot). Doesn't matter if root is on lvm or a plain partition, happens the same way on a guest with no lvm whatsoever and a guest w/lvm. Haven't yet been able to trigger this spew doing heavy I/O within the guest either, thus far it has only been triggered in the initrd. From Jun 28 RHEL 5 meeting:
REPORTER: bstein
STATUS: More progress. Are booting and testing. Fujitsu doesn't
use blktap.
Update: in POST as of Jun 21 PM.
REPORTER: bstein
STATUS: Fujitsu just gave another patch Jun 27.
DECISION: Add to potential Beta respin of kernel.
Copied dzickus on bugzilla.
in 2.6.18-33.el5 You can download this test kernel from http://people.redhat.com/dzickus/el5 Per comment #24, looks like Fujitsu provided the patch. Assume they will test this fix. Confirmed that blktap is building on ia64 as of the -43 kernel An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on the solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2007-0959.html |