Bug 2163338

Summary: Review Request: plasma-bigscreen - A big launcher giving you access to any installed apps and skills.
Product: [Fedora] Fedora Reporter: marcdeop
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: POST --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: massi.ergosum, ngompa13, package-review
Target Milestone: ---Flags: ngompa13: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description marcdeop 2023-01-23 09:23:00 UTC 
Spec URL: https://marcdeop.fedorapeople.org/plasma-bigscreen.spec
SRPM URL: https://marcdeop.fedorapeople.org/plasma-bigscreen-5.27.8-1.fc38.src.rpm
Description: A big launcher giving you access to any installed apps and skills.
Fedora Account System Username: marcdeop
Comment 1 Neal Gompa 2023-01-23 09:26:19 UTC 
Taking this review.
Comment 2 Neal Gompa 2023-01-23 09:28:26 UTC 
Spec review:

> %{_kf5_qmldir}/org/kde/mycroft/bigscreen/*

This means this package doesn't own "%{_kf5_qmldir}/org/kde/mycroft/bigscreen", is this intentional? If you want it to own the directory, just drop the "*" at the end.

> %{_kf5_datadir}/kpackage/genericqml/org.kde.plasma.settings/contents/ui/+mediacenter/*.qml

Do we have other packages in "%{_kf5_datadir}/kpackage/genericqml/org.kde.plasma.settings/contents/ui/+mediacenter"? If so, we should co-own the directory unless we depend on that package.
Comment 3 Jakub Kadlčík 2023-01-23 09:36:43 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5284729
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2163338-plasma-bigscreen/fedora-rawhide-x86_64/05284729-plasma-bigscreen/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service
Comment 4 marcdeop 2023-03-01 22:07:59 UTC 
(In reply to Neal Gompa from comment #2)
> Spec review:
> 
> > %{_kf5_qmldir}/org/kde/mycroft/bigscreen/*
> 
> This means this package doesn't own
> "%{_kf5_qmldir}/org/kde/mycroft/bigscreen", is this intentional? If you want
> it to own the directory, just drop the "*" at the end.
>

Done.

> > %{_kf5_datadir}/kpackage/genericqml/org.kde.plasma.settings/contents/ui/+mediacenter/*.qml
> 
> Do we have other packages in
> "%{_kf5_datadir}/kpackage/genericqml/org.kde.plasma.settings/contents/ui/
> +mediacenter"? If so, we should co-own the directory unless we depend on
> that package.

I am not entirely sure how to check that. As far as I am aware, nothing else drops files on /usr/share/kpackage/genericqml/org.kde.plasma.settings

PS: I updated the spec to the latest 5.27.2 release
Comment 5 Neal Gompa 2023-03-01 22:16:51 UTC 
> %{_kf5_bindir}/plasma-bigscreen-wayland
> %{_kf5_bindir}/plasma-bigscreen-x11

Please separate these out like we did for plasma-workspace.
Comment 6 Neal Gompa 2023-03-01 22:19:33 UTC 
> %{_kf5_datadir}/wayland-sessions/plasma-bigscreen-wayland.desktop
> %{_kf5_datadir}/xsessions/plasma-bigscreen-x11.desktop

These too.
Comment 7 marcdeop 2023-03-02 09:02:54 UTC 
I updated the spec file.

Not sure I did it right though.
Comment 8 Neal Gompa 2023-03-02 11:00:47 UTC 
The wayland subpackage needs to require plasma-workspace-wayland, and the x11-package needs to require plasma-workspace-x11, since it depends on the binaries from those packages.
Comment 9 marcdeop 2023-03-02 11:19:49 UTC 
Fixed
Comment 10 Neal Gompa 2023-03-02 12:14:45 UTC 
You can't use "= %{version}-%{release}", that's not going to be installable (unless you're really lucky). Change it to ">= %{version}" instead.
Comment 11 marcdeop 2023-03-02 12:22:35 UTC 
Fixed
Comment 12 Neal Gompa 2023-03-02 19:50:02 UTC 
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
=======
- Package installs a %{name}.desktop using desktop-file-install or desktop-
  file-validate if there is such a file.
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE is not marked as %license
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/LicensingGuidelines/#_license_text


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* Creative Commons CC0
     1.0", "*No copyright* BSD 2-Clause License", "*No copyright* BSD
     3-Clause License", "GNU General Public License, Version 2", "GNU
     Library General Public License, Version 2.0", "GNU Lesser General
     Public License, Version 2.1", "GNU Lesser General Public License,
     Version 3", "*No copyright* GNU General Public License, Version 3",
     "*No copyright* GNU Lesser General Public License, Version 3", "*No
     copyright* MIT License", "*No copyright* GNU Library General Public
     License, Version 2.0", "*No copyright* GNU General Public License,
     Version 2", "*No copyright* GNU Lesser General Public License GNU
     General Public License, Version 2", "*No copyright* GNU Lesser General
     Public License, Version 2.1", "GNU Library General Public License v2
     or later". 298 files have unknown license. Detailed output of
     licensecheck in /home/ngompa/2163338-plasma-bigscreen/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[!]: Package requires other packages for directories it uses.
     Note: No known owner of
     /usr/share/kpackage/genericqml/org.kde.plasma.settings/contents/ui/+mediacenter,
     /usr/lib64/qt5/qml/org/kde/mycroft,
     /usr/share/kpackage/genericqml/org.kde.plasma.settings/contents/ui,
     /usr/share/kpackage/genericqml/org.kde.plasma.settings,
     /usr/share/kpackage/genericqml/org.kde.plasma.settings/contents
[!]: Package must own all directories that it creates.
     Note: Directories without known owners:
     /usr/share/kpackage/genericqml/org.kde.plasma.settings/contents/ui/+mediacenter,
     /usr/share/kpackage/genericqml/org.kde.plasma.settings,
     /usr/share/kpackage/genericqml/org.kde.plasma.settings/contents,
     /usr/share/plasma/shells, /usr/lib64/qt5/qml/org/kde/mycroft,
     /usr/share/kpackage/genericqml/org.kde.plasma.settings/contents/ui
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[!]: Sources can be downloaded from URI in Source: tag
     Note: Could not download Source0:
     http://download.kde.org/%stable_kf5/plasma/5.27.2/plasma-
     bigscreen-5.27.2.tar.xz
     See: https://docs.fedoraproject.org/en-US/packaging-
     guidelines/SourceURL/
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in plasma-
     bigscreen-wayland , plasma-bigscreen-x11
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 2365440 bytes in /usr/share
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: plasma-bigscreen-5.27.2-4.fc39.x86_64.rpm
          plasma-bigscreen-wayland-5.27.2-4.fc39.x86_64.rpm
          plasma-bigscreen-x11-5.27.2-4.fc39.x86_64.rpm
          plasma-bigscreen-debuginfo-5.27.2-4.fc39.x86_64.rpm
          plasma-bigscreen-debugsource-5.27.2-4.fc39.x86_64.rpm
          plasma-bigscreen-5.27.2-4.fc39.src.rpm
========================================================================================== rpmlint session starts ==========================================================================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp0gti8_mu')]
checks: 31, packages: 6

plasma-bigscreen.src: W: summary-ended-with-dot A big launcher giving you access to any installed apps and skills.
plasma-bigscreen.x86_64: W: summary-ended-with-dot A big launcher giving you access to any installed apps and skills.
plasma-bigscreen.x86_64: E: non-executable-script /usr/bin/mycroft-skill-launcher.py 644 /usr/bin/env python3
plasma-bigscreen.x86_64: W: non-executable-in-bin /usr/bin/mycroft-skill-launcher.py 644
plasma-bigscreen-wayland.x86_64: W: no-manual-page-for-binary plasma-bigscreen-wayland
plasma-bigscreen-x11.x86_64: W: no-manual-page-for-binary plasma-bigscreen-x11
plasma-bigscreen.x86_64: W: no-documentation
plasma-bigscreen-wayland.x86_64: W: no-documentation
plasma-bigscreen-x11.x86_64: W: no-documentation
plasma-bigscreen-wayland.x86_64: E: no-binary
plasma-bigscreen-x11.x86_64: E: no-binary
plasma-bigscreen.x86_64: W: files-duplicate /usr/share/kpackage/kcms/kcm_mediacenter_wifi/contents/ui/images/green-tick-thick.svg /usr/share/kpackage/kcms/kcm_mediacenter_audiodevice/contents/ui/images/green-tick-thick.svg:/usr/share/kpackage/kcms/kcm_mediacenter_bigscreen_settings/contents/ui/images/green-tick-thick.svg:/usr/share/kpackage/kcms/kcm_mediacenter_kdeconnect/contents/ui/images/green-tick-thick.svg
plasma-bigscreen.x86_64: W: files-duplicate /usr/share/kpackage/kcms/kcm_mediacenter_wifi/contents/ui/images/green-tick.svg /usr/share/kpackage/kcms/kcm_mediacenter_audiodevice/contents/ui/images/green-tick.svg:/usr/share/kpackage/kcms/kcm_mediacenter_bigscreen_settings/contents/ui/images/green-tick.svg:/usr/share/kpackage/kcms/kcm_mediacenter_kdeconnect/contents/ui/images/green-tick.svg
plasma-bigscreen.x86_64: W: files-duplicate /usr/share/plasma/plasmoids/org.kde.mycroft.bigscreen.homescreen/metadata.desktop /usr/share/kservices5/plasma-applet-org.kde.mycroft.bigscreen.homescreen.desktop
plasma-bigscreen.x86_64: W: files-duplicate /usr/share/plasma/shells/org.kde.plasma.mycroft.bigscreen/metadata.desktop /usr/share/kservices5/plasma-applet-org.kde.plasma.mycroft.bigscreen.desktop
plasma-bigscreen.x86_64: W: files-duplicate /usr/share/plasma/look-and-feel/org.kde.plasma.mycroft.bigscreen/metadata.desktop /usr/share/kservices5/plasma-lookandfeel-org.kde.plasma.mycroft.bigscreen.desktop
plasma-bigscreen.x86_64: W: files-duplicate /usr/share/locale/zh_TW/LC_MESSAGES/kcm_mediacenter_wifi.mo /usr/share/locale/zh_TW/LC_MESSAGES/kcm_mediacenter_kdeconnect.mo
plasma-bigscreen.x86_64: E: env-script-interpreter /usr/bin/mycroft-skill-launcher.py /usr/bin/env python3
plasma-bigscreen.src: W: description-shorter-than-summary
plasma-bigscreen.x86_64: W: description-shorter-than-summary
========================================================== 6 packages and 0 specfiles checked; 4 errors, 16 warnings, 4 badness; has taken 0.9 s ===========================================================




Rpmlint (debuginfo)
-------------------
Checking: plasma-bigscreen-debuginfo-5.27.2-4.fc39.x86_64.rpm
========================================================================================== rpmlint session starts ==========================================================================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpbwqvdpr8')]
checks: 31, packages: 1

=========================================================== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.3 s ===========================================================





Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 5

plasma-bigscreen.x86_64: W: summary-ended-with-dot A big launcher giving you access to any installed apps and skills.
plasma-bigscreen.x86_64: E: non-executable-script /usr/bin/mycroft-skill-launcher.py 644 /usr/bin/env python3
plasma-bigscreen.x86_64: W: non-executable-in-bin /usr/bin/mycroft-skill-launcher.py 644
plasma-bigscreen-x11.x86_64: W: no-manual-page-for-binary plasma-bigscreen-x11
plasma-bigscreen-wayland.x86_64: W: no-manual-page-for-binary plasma-bigscreen-wayland
plasma-bigscreen.x86_64: W: no-documentation
plasma-bigscreen-x11.x86_64: W: no-documentation
plasma-bigscreen-wayland.x86_64: W: no-documentation
plasma-bigscreen-x11.x86_64: E: no-binary
plasma-bigscreen-wayland.x86_64: E: no-binary
plasma-bigscreen.x86_64: W: files-duplicate /usr/share/kpackage/kcms/kcm_mediacenter_wifi/contents/ui/images/green-tick-thick.svg /usr/share/kpackage/kcms/kcm_mediacenter_audiodevice/contents/ui/images/green-tick-thick.svg:/usr/share/kpackage/kcms/kcm_mediacenter_bigscreen_settings/contents/ui/images/green-tick-thick.svg:/usr/share/kpackage/kcms/kcm_mediacenter_kdeconnect/contents/ui/images/green-tick-thick.svg
plasma-bigscreen.x86_64: W: files-duplicate /usr/share/kpackage/kcms/kcm_mediacenter_wifi/contents/ui/images/green-tick.svg /usr/share/kpackage/kcms/kcm_mediacenter_audiodevice/contents/ui/images/green-tick.svg:/usr/share/kpackage/kcms/kcm_mediacenter_bigscreen_settings/contents/ui/images/green-tick.svg:/usr/share/kpackage/kcms/kcm_mediacenter_kdeconnect/contents/ui/images/green-tick.svg
plasma-bigscreen.x86_64: W: files-duplicate /usr/share/plasma/plasmoids/org.kde.mycroft.bigscreen.homescreen/metadata.desktop /usr/share/kservices5/plasma-applet-org.kde.mycroft.bigscreen.homescreen.desktop
plasma-bigscreen.x86_64: W: files-duplicate /usr/share/plasma/shells/org.kde.plasma.mycroft.bigscreen/metadata.desktop /usr/share/kservices5/plasma-applet-org.kde.plasma.mycroft.bigscreen.desktop
plasma-bigscreen.x86_64: W: files-duplicate /usr/share/plasma/look-and-feel/org.kde.plasma.mycroft.bigscreen/metadata.desktop /usr/share/kservices5/plasma-lookandfeel-org.kde.plasma.mycroft.bigscreen.desktop
plasma-bigscreen.x86_64: W: files-duplicate /usr/share/locale/zh_TW/LC_MESSAGES/kcm_mediacenter_wifi.mo /usr/share/locale/zh_TW/LC_MESSAGES/kcm_mediacenter_kdeconnect.mo
plasma-bigscreen.x86_64: E: env-script-interpreter /usr/bin/mycroft-skill-launcher.py /usr/bin/env python3
plasma-bigscreen.x86_64: W: description-shorter-than-summary
 5 packages and 0 specfiles checked; 4 errors, 14 warnings, 4 badness; has taken 2.0 s 



Unversioned so-files
--------------------
plasma-bigscreen: /usr/lib64/qt5/plugins/kcms/kcm_mediacenter_audiodevice.so
plasma-bigscreen: /usr/lib64/qt5/plugins/kcms/kcm_mediacenter_bigscreen_settings.so
plasma-bigscreen: /usr/lib64/qt5/plugins/kcms/kcm_mediacenter_kdeconnect.so
plasma-bigscreen: /usr/lib64/qt5/plugins/kcms/kcm_mediacenter_wifi.so
plasma-bigscreen: /usr/lib64/qt5/plugins/plasma/applets/plasma_containment_biglauncherhomescreen.so
plasma-bigscreen: /usr/lib64/qt5/qml/org/kde/mycroft/bigscreen/libbigscreenplugin.so

Requires
--------
plasma-bigscreen (rpmlib, GLIBC filtered):
    libKF5Activities.so.5()(64bit)
    libKF5ConfigCore.so.5()(64bit)
    libKF5ConfigWidgets.so.5()(64bit)
    libKF5CoreAddons.so.5()(64bit)
    libKF5I18n.so.5()(64bit)
    libKF5KIOGui.so.5()(64bit)
    libKF5Notifications.so.5()(64bit)
    libKF5Plasma.so.5()(64bit)
    libKF5QuickAddons.so.5()(64bit)
    libKF5Service.so.5()(64bit)
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.15)(64bit)
    libQt5DBus.so.5()(64bit)
    libQt5DBus.so.5(Qt_5)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libQt5Qml.so.5()(64bit)
    libQt5Qml.so.5(Qt_5)(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libkworkspace5.so.5()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    plasma-bigscreen-wayland
    rtld(GNU_HASH)

plasma-bigscreen-wayland (rpmlib, GLIBC filtered):
    /usr/bin/sh
    plasma-bigscreen
    plasma-workspace-wayland

plasma-bigscreen-x11 (rpmlib, GLIBC filtered):
    /usr/bin/sh
    plasma-bigscreen
    plasma-workspace-x11

plasma-bigscreen-debuginfo (rpmlib, GLIBC filtered):

plasma-bigscreen-debugsource (rpmlib, GLIBC filtered):



Provides
--------
plasma-bigscreen:
    libbigscreenplugin.so()(64bit)
    metainfo()
    metainfo(org.kde.mycroft.bigscreen.homescreen.appdata.xml)
    metainfo(org.kde.plasma.mycroft.bigscreen.appdata.xml)
    metainfo(org.kde.plasma.mycroft.bigscreen.metainfo.xml)
    plasma-bigscreen
    plasma-bigscreen(x86-64)

plasma-bigscreen-wayland:
    plasma-bigscreen-wayland
    plasma-bigscreen-wayland(x86-64)

plasma-bigscreen-x11:
    plasma-bigscreen-x11
    plasma-bigscreen-x11(x86-64)

plasma-bigscreen-debuginfo:
    debuginfo(build-id)
    libbigscreenplugin.so-5.27.2-4.fc39.x86_64.debug()(64bit)
    plasma-bigscreen-debuginfo
    plasma-bigscreen-debuginfo(x86-64)

plasma-bigscreen-debugsource:
    plasma-bigscreen-debugsource
    plasma-bigscreen-debugsource(x86-64)



Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -b 2163338 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: C/C++, Shell-api, Generic
Disabled plugins: Python, PHP, SugarActivity, Perl, fonts, Java, Ocaml, R, Haskell
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Comment 13 Neal Gompa 2023-03-02 19:52:40 UTC 
Issues:
=======
> - Package installs a %{name}.desktop using desktop-file-install or desktop-
>   file-validate if there is such a file.

This can be ignored. We don't install desktop files into /usr/share/applications, which is what this is mostly aimed at.

> - If (and only if) the source package includes the text of the license(s)
>   in its own file, then that file, containing the text of the license(s)
>   for the package is included in %license.
>   Note: License file LICENSE is not marked as %license
>   See: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text

This can be ignored. This package follows REUSE-style license documentation.

The rest of the errors/warnings need to be addressed.
Comment 14 Neal Gompa 2023-10-15 16:35:24 UTC 
I think we're in good shape now, so...

PACKAGE APPROVED.
Comment 15 Fedora Admin user for bugzilla script actions 2023-10-15 17:40:05 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/plasma-bigscreen