Bug 2163425

Summary: GCE is not enaabled by default on satellite
Product: Red Hat Satellite Reporter: addubey
Component: Compute Resources - GCEAssignee: Leos Stejskal <lstejska>
Status: CLOSED ERRATA QA Contact: Gaurav Talreja <gtalreja>
Severity: high Docs Contact:
Priority: unspecified    
Version: 6.13.0CC: ehelms, gtalreja, lstejska, rlavi, zhunting
Target Milestone: 6.13.0Keywords: EasyFix, Regression, Triaged, UserExperience
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: satellite-installer-6.13.0.7-1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-05-03 13:24:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2164757, 2173570    
Bug Blocks:    

Description addubey 2023-01-23 11:57:03 UTC
Description of problem: GCE is not enabled by default on satellite


Version-Release number of selected component (if applicable):
6.13 satellite snap 7


How reproducible: 100%


Steps to Reproduce:
1. There is no support to create compute resources for google
2.
3.

Actual results: GCE is not enabled by default on satellite


Expected results: It should be enabled.


Additional info:

Comment 1 Leos Stejskal 2023-01-24 08:27:57 UTC
Hi,
I found that this is actually correct behavior, and it's a bug in the 6.12.

On SAT 6.12 Google compute resource is available even when it's disabled in the installer:

satellite-installer --scenario satellite --help | grep gce
    --[no-]enable-foreman-compute-gce Enable 'foreman_compute_gce' puppet module (default: false)

It was never supposed to be enabled by default, even docs says users have to enable it first [0].
So my suggestion is to open new BZ against 6.12 reporting behavior above and close this one as not a bug.

[0] https://access.redhat.com/documentation/en-us/red_hat_satellite/6.12/html/provisioning_hosts/provisioning_cloud_instances_on_google_compute_engine_provisioning#doc-wrapper

Comment 2 addubey 2023-01-24 12:06:17 UTC
Hey Leos I would suggest adding it as an RFE for GCE like all the other CRs are available by default on the satellite we should have that uniformity maintained with GCE as well.

Comment 3 Eric Helms 2023-01-25 17:33:45 UTC
We effectively have a mismatch in behavior between our packaging and our installer. Our installer says that the compute resources are disabled by default:

foreman::compute::ec2: false
foreman::compute::gce: false
foreman::compute::libvirt: false
foreman::compute::openstack: false
foreman::compute::ovirt: false
foreman::compute::vmware: false


While our packaging requires the compute resource packages, making them available to users:


rpm -q satellite --requires
foreman-ec2
foreman-libvirt
foreman-openstack
foreman-ovirt
foreman-service
foreman-vmware


There are two separate bugs and actions I see here:

 1) Add foreman-google at the packaging layer to ensure it's installed bringing it in-line with the other compute resources
 2) Fix the installer defaults to match packaging (or vice versa)

Comment 4 Marek Hulan 2023-01-26 09:50:24 UTC
I believe this (gce) needs to be enabled by default, to remain consistent with other compute resources and to continue working like with previous Satellite version. I also agree with Eric about the two actions needed. I guess the first one fits this BZ, second probably deserves another one and may not necessarily end up in the same release.

Comment 5 Leos Stejskal 2023-01-26 11:59:32 UTC
Packaging BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2164757

Comment 7 Gaurav Talreja 2023-02-02 20:19:44 UTC
Hi, 

Tested on Satellite 6.13.0 Snap 9.0
Version: rubygem-foreman_google-1.0.2-1.el8sat.noarch

Steps:
1. # satellite-installer --help | grep google
    --[no-]enable-foreman-cli-google Enable 'foreman_cli_google' puppet module (default: true)
    --[no-]enable-foreman-plugin-google Enable 'foreman_plugin_google' puppet module (default: true)

2. # rpm -qa rubygem-foreman_google
rubygem-foreman_google-1.0.2-1.el8sat.noarch

Observation:
Here on the new install, GCE is enabled by default, and as mentioned in comment 3, all other CR's like ec2/libvirt/openstack/ovirt/vmware are also enabled now.

But when upgraded from 6.12.2 to 6.13.0 where rubygem-foreman_google is already installed and GCE CR create works after an upgrade, but installer flags are still set to false.

# satellite-installer --help | grep google
    --[no-]enable-foreman-cli-google Enable 'foreman_cli_google' puppet module (default: false)
    --[no-]enable-foreman-plugin-google Enable 'foreman_plugin_google' puppet module (default: false)

# cat /etc/foreman-installer/scenarios.d/satellite-answers.yaml | grep 'foreman::plugin::google\|foreman::cli::google:'
foreman::cli::google: false
foreman::plugin::google: false

#  rpm -qa rubygem-foreman_google
rubygem-foreman_google-1.0.2-1.el8sat.noarch

Hence, moving this back to ASSIGNED. Please let me know if logs or reproducers are required.


Thanks,
Gaurav

Comment 9 Gaurav Talreja 2023-03-02 17:48:03 UTC
Verified.

Tested upgrade from Satellite 6.12.2 to 6.13.0 Snap 13.0
Version: satellite-installer-6.13.0.7-1.el8sat.noarch

Steps:
1. # satellite-installer --help | grep google
    --[no-]enable-foreman-cli-google Enable 'foreman_cli_google' puppet module (default: true)
    --[no-]enable-foreman-plugin-google Enable 'foreman_plugin_google' puppet module (default: true)

2. # cat /etc/foreman-installer/scenarios.d/satellite-answers.yaml | grep 'foreman::plugin::google\|foreman::cli::google:'
foreman::plugin::google: true
foreman::cli::google: *1

3. # rpm -qa rubygem-foreman_google
rubygem-foreman_google-1.0.3-1.el8sat.noarch

Observation:
foreman_plugin_google and foreman_cli_google plugins are enabled by default on new installs and upgraded systems, also after the upgrade, it continues to work as before.

Comment 12 errata-xmlrpc 2023-05-03 13:24:34 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.13 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:2097