Bug 2163486 (qt6-qtwebengine)
| Summary: | Review Request: qt6-qtwebengine - QtWebEngine components | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jan Grulich <jgrulich> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ngompa13, package-review, sanjay.ankur |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-04-17 05:51:19 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1917559 | ||
|
Description
Jan Grulich
2023-01-23 16:11:52 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/5285415 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2163486-qt6-qtwebengine/srpm-builds/05285415/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service The failure in https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2163486#c1 can be ignored. I just opened the review while the SRPM was being uploaded (it's chromium, takes a while). Taking this review. Spec review: > %global rpm_macros_dir %(d=%{_rpmconfigdir}/macros.d; [ -d $d ] || d=%{_sysconfdir}/rpm; echo $d) Drop this to just use "%{_rpmmacrodir}", since it's supported on all Fedora and EPEL branches. > %if 0%{?rhel} == 7 > BuildRequires: devtoolset-7-toolchain > %endif We're not supporting Qt6 on anything lower than EPEL 9, so we should be able to drop any logic for RHEL < 9. > %if 0%{?fedora} > 35 || 0%{?epel} > 9 > %filetriggerin -- %{_datadir}/hunspell > %else > %filetriggerin -- %{_datadir}/myspell > %endif This should be flipped: %if 0%{?rhel} && 0%{?rhel} < 10 %filetriggerin -- %{_datadir}/myspell %else %filetriggerin -- %{_datadir}/hunspell %endif Fixed issues mentioned above. Spec URL: https://jgrulich.fedorapeople.org/qt6-qtwebengine/qt6-qtwebengine.spec SRPM URL: https://jgrulich.fedorapeople.org/qt6-qtwebengine/qt6-qtwebengine-6.4.2-1.fc37.src.rpm > %if 0%{?fedora} || 0%{?epel} > 8 > # need libicu >= 65, only currently available on Fedora and EPEL 9 > %global use_system_libicu 1 > %endif This is always going to happen, since we're only shipping on Fedora + RHEL 9. Drop the unneeded conditionals. > %if 0%{?fedora} || 0%{?epel} > 7 > # handled by qt6-srpm-macros, which defines %%qt6_qtwebengine_arches > # FIXME use/update qt6_qtwebengine_arches > # 32-bit arches not supported (https://bugreports.qt.io/browse/QTBUG-102143) > ExclusiveArch: aarch64 x86_64 > %endif Same here. > %if 0%{?rhel} == 7 > . /opt/rh/devtoolset-7/enable > %endif Kill this entirely. > %ldconfig_scriptlets Kill this entirely. Fixed issues mentioned above. Spec URL: https://jgrulich.fedorapeople.org/qt6-qtwebengine/qt6-qtwebengine.spec SRPM URL: https://jgrulich.fedorapeople.org/qt6-qtwebengine/qt6-qtwebengine-6.4.2-1.fc37.src.rpm Review notes: * Package is named appropriately * Package builds and installs * Package licensing is correct * No serious issues from rpmlint PACKAGE APPROVED. The Pagure repository was created at https://src.fedoraproject.org/rpms/qt6-qtwebengine Copr build: https://copr.fedorainfracloud.org/coprs/build/5287101 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2163486-qt6-qtwebengine/fedora-rawhide-x86_64/05287101-qt6-qtwebengine/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service Copr build: https://copr.fedorainfracloud.org/coprs/build/5287451 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2163486-qt6-qtwebengine/fedora-rawhide-x86_64/05287451-qt6-qtwebengine/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service |