Bug 216353

Summary:	Review Request: vdr-text2skin - OSD skin plugin for VDR
Product:	[Fedora] Fedora	Reporter:	Ville Skyttä <ville.skytta>
Component:	Package Review	Assignee:	Axel Thimm <axel.thimm>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	Flags:	axel.thimm: fedora-review+ wtogami: fedora-cvs+
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-04-23 19:23:25 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	216355

Description Ville Skyttä 2006-11-19 20:47:22 UTC

http://cachalot.mine.nu/6/SRPMS/vdr-text2skin.spec
http://cachalot.mine.nu/6/SRPMS/vdr-text2skin-1.1-16.20051217cvs.cmn6.src.rpm

This plugin is designed to load and interpret a set of files
describing the layout of VDR's on screen display and to make this
"skin" available to VDR via Setup -> OSD in the main menu.  Of course
it is possible to load more than one text-based skin this way and to
choose between them while running VDR.  All skins may be themeable
(you can create your own color-theme) and translateable as the author
of the skin wishes.

Notes:

The release tag does not follow naming guidelines for pre-release snapshots.  That's cosmetic and intentional and required for upgradeability from my earlier packages elsewhere.

The %pre scriptlet is not pretty, but it's again there for historical reasons and I figure doing the necessary bits of evil before this package enters FE instead of while it's in is better.

Comment 1 Ville Skyttä 2007-04-08 13:38:49 UTC

http://cachalot.mine.nu/6/SRPMS/vdr-text2skin.spec
http://cachalot.mine.nu/6/SRPMS/vdr-text2skin-1.1-18.20051217cvs.cmn6.src.rpm

- Grab potential XML parse buffer overflow fix from upstream CVS.

Comment 2 Axel Thimm 2007-04-22 13:06:41 UTC

- rpmlint checks return:
W: vdr-text2skin dangerous-command-in-%pre cp
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

Everything looks OK including the dangerous cp, so review+ :)

(AFAIU I'm not supposed to touch the assignee or status fields anymore, if I
messed up, ping me)

Comment 3 Ville Skyttä 2007-04-22 19:53:21 UTC

Thanks!

New Package CVS Request
=======================
Package Name: vdr-text2skin
Short Description: OSD skin plugin for VDR
Owners: ville.skytta
Branches: FC-6
InitialCC:

Comment 4 Ville Skyttä 2007-04-23 19:23:25 UTC

Imported and built for FC-6 and devel.