Bug 2164046

Summary:	[Enhancement] Support retry on rpm-ostree rebase
Product:	Red Hat Enterprise Linux 9	Reporter:	Mario Cattamo <mcattamo>
Component:	rpm-ostree	Assignee:	Joseph Marrero <jmarrero>
Status:	CLOSED MIGRATED	QA Contact:	RHCOS SST QE <rhcos-sst-qe>
Severity:	low	Docs Contact:
Priority:	medium
Version:	9.2	CC:	jmarrero, travier, walters
Target Milestone:	rc	Keywords:	MigratedToJIRA
Target Release:	---	Flags:	pm-rhel: mirror+
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-09-13 10:48:17 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Mario Cattamo 2023-01-24 15:10:31 UTC

Description of problem:
We have seen errors during execution of "rpm-ostree rebase" such as

2023-01-24T10:22:58.1065081Z + sudo ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -o ConnectTimeout=5 -i key/ostree_key admin.100.51 'sudo rpm-ostree rebase rhel-edge:rhel/9/x86_64/edge'
2023-01-24T10:22:58.2118842Z Warning: Permanently added '192.168.100.51' (ED25519) to the list of known hosts.
2023-01-24T10:24:51.5735033Z Receiving objects; 95% (598/628) 22.2 MB/s 44.4 MB...done
2023-01-24T10:24:51.8932917Z [0m[31merror: [0mWhile pulling rhel/9/x86_64/edge: While fetching http://192.168.100.1/repo/objects/4f/b22270f0a52fb1d6ffafd6a6daaf80711cca57fe4049df3f54176a31bcfe1a.filez: [56] Failure when receiving data from the peer
2023-01-24T10:24:57.1474998Z ##[error]Process completed with exit code 1.

The failure is not persistent, and is normally fixed after retrying several times. Thus, it would be useful to support retry in 'rpm-ostree rebase' as an enhancement.

Version-Release number of selected component (if applicable):
rpm-ostree 2022.19-3.el9

How reproducible:


Steps to Reproduce:
1. Deploy a RHEL-9.2 VM from PSI openstack
2. git clone https://github.com/virt-s1/rhel-edge.git
3. cd rhel-edge && ./ostree-8-to-9.sh

Actual results:
Error [56] Failure when receiving data from the peer

Expected results:
No error

Additional info:

Comment 1 Colin Walters 2023-03-29 18:13:51 UTC

https://github.com/ostreedev/ostree/issues/2570
https://github.com/ostreedev/ostree/issues/2022
are related.

I think we should probably indeed retry say 3 times on things like this.

One messy thing here is determining which errors we retry on; we are sometimes squashing errors here, particularly with the container flow.  Correctly distinguishing e.g. "network failure" from the skopeo bits is going to need work on that side.

For pure libostree I think we are already getting a GError we can match on, but this needs investigation too.

Comment 2 RHEL Program Management 2023-09-13 10:46:16 UTC

Issue migration from Bugzilla to Jira is in process at this time. This will be the last message in Jira copied from the Bugzilla bug.

Comment 3 RHEL Program Management 2023-09-13 10:48:17 UTC

This BZ has been automatically migrated to the issues.redhat.com Red Hat Issue Tracker. All future work related to this report will be managed there.

Due to differences in account names between systems, some fields were not replicated.  Be sure to add yourself to Jira issue's "Watchers" field to continue receiving updates and add others to the "Need Info From" field to continue requesting information.

To find the migrated issue, look in the "Links" section for a direct link to the new issue location. The issue key will have an icon of 2 footprints next to it, and begin with "RHEL-" followed by an integer.  You can also find this issue by visiting https://issues.redhat.com/issues/?jql= and searching the "Bugzilla Bug" field for this BZ's number, e.g. a search like:

"Bugzilla Bug" = 1234567

In the event you have trouble locating or viewing this issue, you can file an issue by sending mail to rh-issues. You can also visit https://access.redhat.com/articles/7032570 for general account information.